You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 02:08:44 UTC

[GitHub] [pulsar] coderzc commented on a diff in pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch

coderzc commented on code in PR #17369:
URL: https://github.com/apache/pulsar/pull/17369#discussion_r960158252


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java:
##########
@@ -84,6 +83,7 @@ private Set<String> publishMessages(String topic, int count, boolean batching) t
             .enableBatching(batching)
             // easier to create enough batches with a small batch size
             .batchingMaxMessages(10)
+            .batchingMaxPublishDelay(1, TimeUnit.MINUTES)

Review Comment:
   It is make sense, we can flush manually after sent the last message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org