You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "John (JIRA)" <ji...@apache.org> on 2019/08/13 12:54:00 UTC

[jira] [Updated] (NETBEANS-2976) EE Deployment module not working with git-commit-id-plugin and finalName

     [ https://issues.apache.org/jira/browse/NETBEANS-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John updated NETBEANS-2976:
---------------------------
    Description: 
Have have nested maven project that uses plugin `pl.project13.maven:git-commit-id-plugin` in the parent pom, and a child project overriding it's artifact name in it's pom.  When the `finalName` setting in the child project container properties created by the plugin, the NB deployment module can't find the packaged ear for deployment.

 

Here is the parent pom.xml:

 
{code:java}
<plugin>
 <groupId>pl.project13.maven</groupId>
 <artifactId>git-commit-id-plugin</artifactId>
 <version>2.2.6</version>
 <executions>
   <execution>
     <id>get-the-git-infos</id>
     <goals>
       <goal>revision</goal>
     </goals>
     <phase>initialize</phase>
   </execution>
   <execution>
     <id>validate-the-git-infos</id>
     <goals>
       <goal>validateRevision</goal>
     </goals>
     <phase>package</phase>
   </execution>
  </executions>
  <configuration>
  <dotGitDirectory>${project.basedir}/.git</dotGitDirectory>
  <prefix>git</prefix>
  <dateFormat>yyyyMMdd'T'HHmm</dateFormat>
  <verbose>false</verbose>
  <generateGitPropertiesFile>false</generateGitPropertiesFile>
  <skipPoms>false</skipPoms>
  <injectAllReactorProjects>false</injectAllReactorProjects>   
  <failOnNoGitDirectory>true</failOnNoGitDirectory> 
  <failOnUnableToExtractRepoInfo>true</failOnUnableToExtractRepoInfo>
  <skip>false</skip> 
  <offline>false</offline> <runOnlyOnce>false</runOnlyOnce> 
  <useBranchNameFromBuildEnvironment>true</useBranchNameFromBuildEnvironment> 
  <injectIntoSysProperties>true</injectIntoSysProperties>
  <includeOnlyProperties>
    <includeOnlyProperty>^git.commit.id.abbrev$</includeOnlyProperty> 
    <includeOnlyProperty>^git.commit.time$</includeOnlyProperty> 
    <includeOnlyProperty>^git.build.version$</includeOnlyProperty> 
    <includeOnlyProperty>^git.branch$</includeOnlyProperty>
  </includeOnlyProperties>
 </configuration>
</plugin>{code}

  

 

Here is the child pom.xml:

 
{code:java}
<build>
  <finalName>${project.artifactId}${project.version}${git.branch}${git.commit.time}${git.commit.id.abbrev}</finalName>
</build>{code}

  

{{And IDE.log:}}
{code:java}
INFO [org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment]
org.netbeans.modules.j2ee.deployment.impl.TargetServer$NoArchiveException: No archive for deployment
    at org.netbeans.modules.j2ee.deployment.impl.TargetServer.deploy(TargetServer.java:675)
[catch] at org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment.deploy(Deployment.java:221)
    at org.netbeans.modules.maven.j2ee.execution.DeploymentHelper.perform(DeploymentHelper.java:185)
    at org.netbeans.modules.maven.j2ee.execution.CoSAlternativeExecutorImpl.execute(CoSAlternativeExecutorImpl.java:67)
    at org.netbeans.modules.maven.cos.CoSAlternativeExecutor.execute(CoSAlternativeExecutor.java:64)
    at org.netbeans.modules.maven.cos.CosChecker.checkRunMainClass(CosChecker.java:186)
    at org.netbeans.modules.maven.cos.CosChecker.checkRunConfig(CosChecker.java:140)
    at org.netbeans.modules.maven.execute.MavenCommandLineExecutor.run(MavenCommandLineExecutor.java:213)
    at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:128){code}
 

  was:
Have have nested maven project that uses plugin `pl.project13.maven:git-commit-id-plugin` in the parent pom, and a child project overriding it's artifact name in it's pom.  When the `finalName` setting in the child project container properties created by the plugin, the NB deployment module can't find the packaged ear for deployment.

 

Here is the parent pom.xml:
            <plugin>                <groupId>pl.project13.maven</groupId>                <artifactId>git-commit-id-plugin</artifactId>                <version>2.2.6</version>                <executions>                    <execution>                        <id>get-the-git-infos</id>                        <goals>                            <goal>revision</goal>                        </goals>                        <phase>initialize</phase>                    </execution>                    <execution>                        <id>validate-the-git-infos</id>                        <goals>                            <goal>validateRevision</goal>                        </goals>                        <phase>package</phase>                    </execution>                </executions>                <configuration>                    <dotGitDirectory>${project.basedir}/.git</dotGitDirectory>                    <prefix>git</prefix>                    <dateFormat>yyyyMMdd'T'HHmm</dateFormat>                    <verbose>false</verbose>                    <generateGitPropertiesFile>false</generateGitPropertiesFile>                    <skipPoms>false</skipPoms>                    <injectAllReactorProjects>false</injectAllReactorProjects>                    <failOnNoGitDirectory>true</failOnNoGitDirectory>                    <failOnUnableToExtractRepoInfo>true</failOnUnableToExtractRepoInfo>                    <skip>false</skip>                    <offline>false</offline>                    <runOnlyOnce>false</runOnlyOnce>                    <useBranchNameFromBuildEnvironment>true</useBranchNameFromBuildEnvironment>                    <injectIntoSysProperties>true</injectIntoSysProperties>                    <includeOnlyProperties>                      <includeOnlyProperty>^git.commit.id.abbrev$</includeOnlyProperty>                      <includeOnlyProperty>^git.commit.time$</includeOnlyProperty>                      <includeOnlyProperty>^git.build.version$</includeOnlyProperty>                      <includeOnlyProperty>^git.branch$</includeOnlyProperty>                    </includeOnlyProperties>                </configuration>            </plugin>
 

Here is the child pom.xml:
<build>

<finalName>${project.artifactId}-${project.version}-${git.branch}-${git.commit.time}-${git.commit.id.abbrev}</finalName>
</build>
 

{{And IDE.log:}}
{code:java}
INFO [org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment]
org.netbeans.modules.j2ee.deployment.impl.TargetServer$NoArchiveException: No archive for deployment
    at org.netbeans.modules.j2ee.deployment.impl.TargetServer.deploy(TargetServer.java:675)
[catch] at org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment.deploy(Deployment.java:221)
    at org.netbeans.modules.maven.j2ee.execution.DeploymentHelper.perform(DeploymentHelper.java:185)
    at org.netbeans.modules.maven.j2ee.execution.CoSAlternativeExecutorImpl.execute(CoSAlternativeExecutorImpl.java:67)
    at org.netbeans.modules.maven.cos.CoSAlternativeExecutor.execute(CoSAlternativeExecutor.java:64)
    at org.netbeans.modules.maven.cos.CosChecker.checkRunMainClass(CosChecker.java:186)
    at org.netbeans.modules.maven.cos.CosChecker.checkRunConfig(CosChecker.java:140)
    at org.netbeans.modules.maven.execute.MavenCommandLineExecutor.run(MavenCommandLineExecutor.java:213)
    at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:128){code}
 


> EE Deployment module not working with git-commit-id-plugin and finalName
> ------------------------------------------------------------------------
>
>                 Key: NETBEANS-2976
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-2976
>             Project: NetBeans
>          Issue Type: Bug
>    Affects Versions: 11.1
>         Environment: Ubuntu Linux 19.04, Netbeans 11.1, Oracle JDK 1.8.0_201
>            Reporter: John
>            Priority: Minor
>
> Have have nested maven project that uses plugin `pl.project13.maven:git-commit-id-plugin` in the parent pom, and a child project overriding it's artifact name in it's pom.  When the `finalName` setting in the child project container properties created by the plugin, the NB deployment module can't find the packaged ear for deployment.
>  
> Here is the parent pom.xml:
>  
> {code:java}
> <plugin>
>  <groupId>pl.project13.maven</groupId>
>  <artifactId>git-commit-id-plugin</artifactId>
>  <version>2.2.6</version>
>  <executions>
>    <execution>
>      <id>get-the-git-infos</id>
>      <goals>
>        <goal>revision</goal>
>      </goals>
>      <phase>initialize</phase>
>    </execution>
>    <execution>
>      <id>validate-the-git-infos</id>
>      <goals>
>        <goal>validateRevision</goal>
>      </goals>
>      <phase>package</phase>
>    </execution>
>   </executions>
>   <configuration>
>   <dotGitDirectory>${project.basedir}/.git</dotGitDirectory>
>   <prefix>git</prefix>
>   <dateFormat>yyyyMMdd'T'HHmm</dateFormat>
>   <verbose>false</verbose>
>   <generateGitPropertiesFile>false</generateGitPropertiesFile>
>   <skipPoms>false</skipPoms>
>   <injectAllReactorProjects>false</injectAllReactorProjects>   
>   <failOnNoGitDirectory>true</failOnNoGitDirectory> 
>   <failOnUnableToExtractRepoInfo>true</failOnUnableToExtractRepoInfo>
>   <skip>false</skip> 
>   <offline>false</offline> <runOnlyOnce>false</runOnlyOnce> 
>   <useBranchNameFromBuildEnvironment>true</useBranchNameFromBuildEnvironment> 
>   <injectIntoSysProperties>true</injectIntoSysProperties>
>   <includeOnlyProperties>
>     <includeOnlyProperty>^git.commit.id.abbrev$</includeOnlyProperty> 
>     <includeOnlyProperty>^git.commit.time$</includeOnlyProperty> 
>     <includeOnlyProperty>^git.build.version$</includeOnlyProperty> 
>     <includeOnlyProperty>^git.branch$</includeOnlyProperty>
>   </includeOnlyProperties>
>  </configuration>
> </plugin>{code}
>   
>  
> Here is the child pom.xml:
>  
> {code:java}
> <build>
>   <finalName>${project.artifactId}${project.version}${git.branch}${git.commit.time}${git.commit.id.abbrev}</finalName>
> </build>{code}
>   
> {{And IDE.log:}}
> {code:java}
> INFO [org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment]
> org.netbeans.modules.j2ee.deployment.impl.TargetServer$NoArchiveException: No archive for deployment
>     at org.netbeans.modules.j2ee.deployment.impl.TargetServer.deploy(TargetServer.java:675)
> [catch] at org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment.deploy(Deployment.java:221)
>     at org.netbeans.modules.maven.j2ee.execution.DeploymentHelper.perform(DeploymentHelper.java:185)
>     at org.netbeans.modules.maven.j2ee.execution.CoSAlternativeExecutorImpl.execute(CoSAlternativeExecutorImpl.java:67)
>     at org.netbeans.modules.maven.cos.CoSAlternativeExecutor.execute(CoSAlternativeExecutor.java:64)
>     at org.netbeans.modules.maven.cos.CosChecker.checkRunMainClass(CosChecker.java:186)
>     at org.netbeans.modules.maven.cos.CosChecker.checkRunConfig(CosChecker.java:140)
>     at org.netbeans.modules.maven.execute.MavenCommandLineExecutor.run(MavenCommandLineExecutor.java:213)
>     at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:128){code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists