You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Abhishek Umarjikar (Jira)" <ji...@apache.org> on 2025/04/03 12:53:00 UTC
[jira] [Comment Edited] (SOLR-17703) BinaryResponseParser and BinaryRequestWriter rename to "JavaBin..."
[ https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940692#comment-17940692 ]
Abhishek Umarjikar edited comment on SOLR-17703 at 4/3/25 12:52 PM:
--------------------------------------------------------------------
[~dsmiley] Added [PR|https://github.com/apache/solr/pull/3307]
was (Author: JIRAUSER309064):
Added [PR|https://github.com/apache/solr/pull/3307]
> BinaryResponseParser and BinaryRequestWriter rename to "JavaBin..."
> -------------------------------------------------------------------
>
> Key: SOLR-17703
> URL: https://issues.apache.org/jira/browse/SOLR-17703
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Priority: Blocker
> Labels: newdev, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SolrJ BinaryRequestWriter and BinaryResponseParser should be renamed to replace "Binary" with "JavaBin". Same with StreamingBinaryResponseParser. This clarifies that they are for "JavaBin" specifically, and not binary generically, and it's also more consistent with the other uses of "JavaBin" named things. The poor naming has led to accidental misuse of these. Separately in another issue, the Solr side JavaBinResponseWriter was renamed from a worse name.
> 10.0 only, obviously.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org