You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/02/12 16:21:42 UTC

[GitHub] justinleet commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

justinleet commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple
URL: https://github.com/apache/metron/pull/1335#discussion_r256032128
 
 

 ##########
 File path: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
 ##########
 @@ -326,7 +328,6 @@ public void flushTimeouts(
           || clock.currentTimeMillis() - batchTimeoutInfo[LAST_CREATE_TIME_MS] >= batchTimeoutInfo[TIMEOUT_MS]) {
         flush(sensorType, bulkMessageWriter, configurations, messageGetStrategy
 
 Review comment:
   Can you add to the comment with info about the ConcurrentModificationException? Without knowing why we're creating a copy of the keyset, it's not obvious.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services