[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5854: HCL fix compound expression grammar

["lkishalmi (via GitHub)" <gi...@apache.org>]

lkishalmi commented on code in PR #5854:
URL: https://github.com/apache/netbeans/pull/5854#discussion_r1173258620


##########
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/grammar/g4/HCLExpressionParser.g4:
##########
@@ -21,8 +21,9 @@ options { tokenVocab = HCLLexer; }
 
 expression
     : exprTerm
-    | operation
-    | <assoc=right> expression QUESTION expression COLON expression
+    | <assoc=right> unaryOperator expression
+    | expression binaryOperator expression

Review Comment:
   Thank you!  I had to lift all operators to expression level, for the adjustment.
   Created a few tests as well. My own Terraform files are still parsing well.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists