You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/05/28 11:02:09 UTC
Re: Review Request 67339: Modified launch.cpp to write its logs into
cerr.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67339/#review203946
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On May 28, 2018, 10:37 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67339/
> -----------------------------------------------------------
>
> (Updated May 28, 2018, 10:37 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8961
> https://issues.apache.org/jira/browse/MESOS-8961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `containerizer/mesos/launch.cpp` wrote some of its output into
> `cout` and some into `cerr` without a clear distinction as to
> why it was done in some cases.
>
> Moreover, it is standard for logging utilities to write their
> output into cerr, and finally in Mesos clog should probably
> kept clean for the task output in cases there consumers of the
> task which process the cout of it.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp 70b7805f88e6475992bc8408024eba78d01e341d
>
>
> Diff: https://reviews.apache.org/r/67339/diff/1/
>
>
> Testing
> -------
>
> ```sh
> make check
> ```
>
>
> Thanks,
>
> Alexander Rojas
>
>