You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/06 15:22:04 UTC
[GitHub] [rocketmq-exporter] francisoliverlee opened a new pull request, #103: add producer count metrics
francisoliverlee opened a new pull request, #103:
URL: https://github.com/apache/rocketmq-exporter/pull/103
## What is the purpose of the change
add producer count metrics.
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] francisoliverlee merged pull request #103: add producer count metrics
Posted by GitBox <gi...@apache.org>.
francisoliverlee merged PR #103:
URL: https://github.com/apache/rocketmq-exporter/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] codecov-commenter commented on pull request #103: add producer count metrics
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #103:
URL: https://github.com/apache/rocketmq-exporter/pull/103#issuecomment-1174524750
# [Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#103](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e1edb4) into [master](https://codecov.io/gh/apache/rocketmq-exporter/commit/86a6255009c31d51d2d4ca29c38240a2ddc80f13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86a6255) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #103 +/- ##
===========================================
- Coverage 0.35% 0.33% -0.02%
Complexity 2 2
===========================================
Files 30 31 +1
Lines 2270 2358 +88
Branches 197 207 +10
===========================================
Hits 8 8
- Misses 2262 2350 +88
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rocketmq/exporter/RocketMQExporterApplication.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL1JvY2tldE1RRXhwb3J0ZXJBcHBsaWNhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...cketmq/exporter/collector/RMQMetricsCollector.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL2NvbGxlY3Rvci9STVFNZXRyaWNzQ29sbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/rocketmq/exporter/model/BrokerRuntimeStats.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL21vZGVsL0Jyb2tlclJ1bnRpbWVTdGF0cy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...er/model/metrics/producer/ProducerCountMetric.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL21vZGVsL21ldHJpY3MvcHJvZHVjZXIvUHJvZHVjZXJDb3VudE1ldHJpYy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...xporter/model/metrics/producer/ProducerMetric.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL21vZGVsL21ldHJpY3MvcHJvZHVjZXIvUHJvZHVjZXJNZXRyaWMuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...cketmq/exporter/service/client/MQAdminExtImpl.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL3NlcnZpY2UvY2xpZW50L01RQWRtaW5FeHRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...che/rocketmq/exporter/task/MetricsCollectTask.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL3Rhc2svTWV0cmljc0NvbGxlY3RUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86a6255...5e1edb4](https://codecov.io/gh/apache/rocketmq-exporter/pull/103?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] francisoliverlee commented on pull request #103: add producer count metrics
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on PR #103:
URL: https://github.com/apache/rocketmq-exporter/pull/103#issuecomment-1147571592
this PR should not be merged util RocketMQ 4.9.4 relase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org