You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/01/05 21:28:34 UTC
[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1399
NIFI-3251: Updating authorization requirements for removing components
- Requiring WRITE permissions to the parent resource when attempting to remove a component.
- Updating expired certificates in the REST API integration tests.
NOTE: There are a couple places (templates and access policies) where the UI does not know if the user will have all required permissions ahead of time. I updated the UI where these details are known but think it makes sense to add these changes and update the remaining places one those details are available. The behavior now will simply provide a dialog indicating that the user does not have permissions to perform the desired action.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1399
----
commit b406a6f8db405162d9f8de41fcf7d252ec142418
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-01-05T21:21:50Z
NIFI-3251:
- Requiring WRITE permissions to the parent resource when attempting to remove a component.
- Updating expired certificates in the REST API integration tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1399
@mcgilman I think this looks good, it worked well in my testing. The integration tests are passing again. These changes didn't break any tests, but none of the tests in nifi-web-api really exercise them, and the test framework does not make it easy to add something for this. At the risk of being a bad committer, I merged anyways.
Thanks for contributing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1399
@mcgilman Did you consider modifying the `isDeletable` method in nf-canvas-utils to check process group write access? This is currently enabling the Delete button in the operate palette when the user has write permissions on a processor but not on a process group.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1399#discussion_r97633156
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-services.js ---
@@ -497,6 +497,36 @@ nf.ControllerServices = (function () {
};
/**
+ * Determines if the user is authorized for the parent of the specified controller service.
+ *
+ * @param dataContext
+ * @returns {boolean}
+ */
+ var isAuthorizedForControllerServiceParent = function (dataContext) {
--- End diff --
Agreed. Will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1399
I've updated the PR with the changes suggested thus far. Thanks again @jvwing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1399
Yep, I'm tracking. Looks like that will provide more consistent coverage when checking if that behavior should be available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1399
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---