You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "AnonHxy (via GitHub)" <gi...@apache.org> on 2023/10/08 06:20:13 UTC
[PR] [fix][bk] Fix the var name for IsolationGroups [pulsar]
AnonHxy opened a new pull request, #21320:
URL: https://github.com/apache/pulsar/pull/21320
### Motivation
Fix the var name for IsolationGroups. The name `allBookies` is a little confused.
### Modifications
`allBookies` -> `allGroups`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][bk] Fix the var name for IsolationGroups [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21320:
URL: https://github.com/apache/pulsar/pull/21320#issuecomment-1752018138
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21320](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (26de20f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/dbb157793b90e203f01a630fb0f0abafbb337762?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dbb1577) will **increase** coverage by `36.50%`.
> Report is 5 commits behind head on master.
> The diff coverage is `80.10%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21320 +/- ##
=============================================
+ Coverage 36.69% 73.19% +36.50%
- Complexity 12193 32500 +20307
=============================================
Files 1698 1887 +189
Lines 130509 140228 +9719
Branches 14261 15439 +1178
=============================================
+ Hits 47889 102645 +54756
+ Misses 76281 29474 -46807
- Partials 6339 8109 +1770
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.08% <7.85%> (-0.05%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.68% <7.32%> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.51% <80.10%> (+40.63%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/bookkeeper/mledger/impl/ManagedCursorImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRDdXJzb3JJbXBsLmphdmE=) | `78.93% <100.00%> (+33.75%)` | :arrow_up: |
| [.../bookkeeper/mledger/impl/NonDurableCursorImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL05vbkR1cmFibGVDdXJzb3JJbXBsLmphdmE=) | `85.41% <100.00%> (ø)` | |
| [...ookie/rackawareness/BookieRackAffinityMapping.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9ib29raWUvcmFja2F3YXJlbmVzcy9Cb29raWVSYWNrQWZmaW5pdHlNYXBwaW5nLmphdmE=) | `80.71% <100.00%> (+10.71%)` | :arrow_up: |
| [...areness/IsolatedBookieEnsemblePlacementPolicy.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9ib29raWUvcmFja2F3YXJlbmVzcy9Jc29sYXRlZEJvb2tpZUVuc2VtYmxlUGxhY2VtZW50UG9saWN5LmphdmE=) | `87.02% <100.00%> (+87.02%)` | :arrow_up: |
| [...n/java/org/apache/pulsar/broker/PulsarService.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9QdWxzYXJTZXJ2aWNlLmphdmE=) | `82.69% <100.00%> (+14.01%)` | :arrow_up: |
| [...ker/loadbalance/extensions/models/TopKBundles.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL21vZGVscy9Ub3BLQnVuZGxlcy5qYXZh) | `90.78% <100.00%> (+90.78%)` | :arrow_up: |
| [...org/apache/pulsar/broker/loadbalance/LoadData.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9Mb2FkRGF0YS5qYXZh) | `91.66% <0.00%> (+25.00%)` | :arrow_up: |
| [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `80.80% <80.00%> (+32.87%)` | :arrow_up: |
| [...ache/pulsar/broker/namespace/NamespaceService.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9uYW1lc3BhY2UvTmFtZXNwYWNlU2VydmljZS5qYXZh) | `72.32% <75.00%> (+28.67%)` | :arrow_up: |
| [...xtensions/channel/ServiceUnitStateChannelImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9leHRlbnNpb25zL2NoYW5uZWwvU2VydmljZVVuaXRTdGF0ZUNoYW5uZWxJbXBsLmphdmE=) | `84.48% <58.82%> (+83.94%)` | :arrow_up: |
| ... and [1 more](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1442 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21320/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][bk] Fix the var name for IsolationGroups [pulsar]
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy merged PR #21320:
URL: https://github.com/apache/pulsar/pull/21320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org