You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by dsyer <gi...@git.apache.org> on 2015/07/16 13:59:55 UTC
[GitHub] maven pull request: Locate .mvn in current directory
GitHub user dsyer opened a pull request:
https://github.com/apache/maven/pull/58
Locate .mvn in current directory
There was a problem with the logic in the while loop that detects
the base dir - it should first look in the current directory,
otherwise you can't build in a directory with local settings because
it will always climb up and find .mvn in a parent directory (e.g. user's
home).
Fixes MNG-5858
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsyer/maven fix/basedir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 6da2911c5fc5f1deb4b1ef5d617e091005169933
Author: Dave Syer <ds...@pivotal.io>
Date: 2015-07-16T11:58:58Z
Locate .mvn in current directory
There was a problem with the logic in the while loop that detects
the base dir - it should first look in the current directory,
otherwise you can't build in a directory with local settings because
it will always climb up and find .mvn in a parent directory (e.g. user's
home).
Fixes MNG-5858
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Posted by fbricon <gi...@git.apache.org>.
Github user fbricon commented on the pull request:
https://github.com/apache/maven/pull/58#issuecomment-139963041
Seems to be duplicated by #40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Posted by dsyer <gi...@git.apache.org>.
Github user dsyer commented on the pull request:
https://github.com/apache/maven/pull/58#issuecomment-122027101
My reading of the windows script is it works already (but it's harder to tell with batch scripts, for me at least).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/58#issuecomment-140046053
@fbricon, @dsyer's logic was also integrated into the Maven Wrapper. I'll release the Maven Wrapper today with that fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Posted by agudian <gi...@git.apache.org>.
Github user agudian commented on the pull request:
https://github.com/apache/maven/pull/58#issuecomment-121962243
Hi,
Thanks for the patch!
Are the windows-scripts also affected by the bug and could use a fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org