You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/12/21 00:04:29 UTC

[GitHub] brooklyn-library pull request #145: Fix NPE in CouchbaseCluster enricher

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-library/pull/145

    Fix NPE in CouchbaseCluster enricher

    I saw this exception, which would happen when the enricher is triggered with the sensor `couchbase.cluster.clusterEntities` that has a null value.
    
    ```
    2017-12-20T23:25:58,096 WARN  123 o.a.b.c.m.i.LocalSubscriptionManager [ager-uluKzucE-12] Error processing subscriptions to LSM.publishInitial(CouchbaseClusterImpl{id=fzixius98s}.Sensor: couchbase.cluster.clusterEntities (java.util.Set)=null @ 1513812358095): java.lang.NullPointerException
    java.lang.NullPointerException: null
            at org.apache.brooklyn.entity.nosql.couchbase.CouchbaseClusterImpl$ListOfHostAndPort.apply(CouchbaseClusterImpl.java:293) ~[?:?]
            at org.apache.brooklyn.entity.nosql.couchbase.CouchbaseClusterImpl$ListOfHostAndPort.apply(CouchbaseClusterImpl.java:290) ~[?:?]
            at org.apache.brooklyn.enricher.stock.Transformer$4.apply(Transformer.java:98) ~[?:?]
            at org.apache.brooklyn.enricher.stock.Transformer$4.apply(Transformer.java:95) ~[?:?]
            at org.apache.brooklyn.enricher.stock.AbstractTransformer.compute(AbstractTransformer.java:163) ~[?:?]
            at org.apache.brooklyn.enricher.stock.AbstractTransformer.onEvent(AbstractTransformer.java:157) ~[?:?]
            at org.apache.brooklyn.core.mgmt.internal.LocalSubscriptionManager$1.run(LocalSubscriptionManager.java:351) ~[?:?]
            at org.apache.brooklyn.core.mgmt.internal.LocalSubscriptionManager.submitPublishEvent(LocalSubscriptionManager.java:370) ~[?:?]
            at org.apache.brooklyn.core.mgmt.internal.LocalSubscriptionManager.lambda$subscribe$0(LocalSubscriptionManager.java:204) ~[?:?]
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
            at org.apache.brooklyn.util.core.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:565) [123:org.apache.brooklyn.core:1.0.0.20171219_1516]
            at org.apache.brooklyn.util.core.task.SingleThreadedScheduler$1.call(SingleThreadedScheduler.java:116) [123:org.apache.brooklyn.core:1.0.0.20171219_1516]
            at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
            at java.lang.Thread.run(Thread.java:748) [?:?]
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-library fix-npe-couchbase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-library/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit 4a5208e582ae94e552cc9cb4135487696c61dac3
Author: Aled Sage <al...@...>
Date:   2017-12-20T23:57:41Z

    Fix NPE in CouchbaseCluster enricher

----


---

[GitHub] brooklyn-library issue #145: Fix NPE in CouchbaseCluster enricher

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-library/pull/145
  
    LGTM, thanks @aledsage 


---

[GitHub] brooklyn-library pull request #145: Fix NPE in CouchbaseCluster enricher

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-library/pull/145


---