[GitHub] [hadoop] goiri commented on a diff in pull request #5335: YARN-11426. Improve YARN NodeLabel Memory Display.

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5335:
URL: https://github.com/apache/hadoop/pull/5335#discussion_r1093596818


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/Resource.java:
##########
@@ -464,7 +464,7 @@ public int compareTo(Resource other) {
 
   @Override
   public String toString() {
-    return getFormattedString(String.valueOf(getMemorySize()));
+    return getFormattedString();

Review Comment:
   Isn't it dangerous to do it for everything and not just for the UI?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org