[PR] Clarify Breeze CI image build helper names [airflow]

["Andrushika (via GitHub)" <gi...@apache.org>]

Andrushika opened a new pull request, #71912:
URL: https://github.com/apache/airflow/pull/71912

   ## Why
   While I was adding cross-worktree image reuse in #71886, some of the functions' name makes the code tracing harder:
   - `rebuild_or_pull_ci_image_if_needed`: it was introduced in #24402, when passing an image tag made the helper pull that CI image. The pull path was later removed, but the old name remained. 
   - `check_if_image_building_is_needed` calls `should_we_run_the_build`; the similar names hide that the inner helper checks source changes and asks the user for confirmation.
   
   ## What
   
   Rename the helpers to `build_ci_image_if_needed` and `confirm_build_if_sources_changed`. Update their call sites, docstrings, mocks, and test names without changing behavior.
   
   related: #71886
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code and Codex (GPT-5)
   
   Generated-by: Claude Code and Codex (GPT-5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify Breeze CI image build helper names [airflow]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #71912:
URL: https://github.com/apache/airflow/pull/71912#issuecomment-5369410973

   ### Backport failed to create: v3-3-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/32478562812'> Run details </a>
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>v3-3-test</td>
           <td><a href="https://github.com/apache/airflow/commit/c322a556496d8afeb3af0f506c3b8300fae285d7"><img src='https://img.shields.io/badge/Commit-c322a55-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker c322a55 v3-3-test
   ```
   
   This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   
   If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify Breeze CI image build helper names [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #71912:
URL: https://github.com/apache/airflow/pull/71912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org