You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sebastien Briquet (JIRA)" <ji...@apache.org> on 2012/10/22 20:40:13 UTC
[jira] [Created] (WICKET-4831) Split custom CSS for Feedback
message (list and label)
Sebastien Briquet created WICKET-4831:
-----------------------------------------
Summary: Split custom CSS for Feedback message (list and label)
Key: WICKET-4831
URL: https://issues.apache.org/jira/browse/WICKET-4831
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5.8
Reporter: Sebastien Briquet
Priority: Minor
Hi,
Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
Both methods return #getCSSClass by default for backward compatibility.
Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).
The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.
Best regards,
Sebastien
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4831) Append the feedback message CSS
class instead of overriding it
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489543#comment-13489543 ]
Sven Meier commented on WICKET-4831:
------------------------------------
You'll have to remove class="errorlevel" from Feedback's markup.
> Append the feedback message CSS class instead of overriding it
> --------------------------------------------------------------
>
> Key: WICKET-4831
> URL: https://issues.apache.org/jira/browse/WICKET-4831
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Sebastien Briquet
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: patch
> Fix For: 6.3.0, 1.5.9
>
> Attachments: 0001-Updated-FeedbackPanel-added-getListCSSClass-getLabel.patch
>
>
> Hi,
> Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
> Both methods return #getCSSClass by default for backward compatibility.
> Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).
> The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.
> Best regards,
> Sebastien
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4831) Append the feedback message CSS
class instead of overriding it
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4831.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.9
6.3.0
Assignee: Martin Grigorov
As decided in the linked discussion for 1.5.x/6.x series we will just append the feedback message class to the <li> and <span> elements.
> Append the feedback message CSS class instead of overriding it
> --------------------------------------------------------------
>
> Key: WICKET-4831
> URL: https://issues.apache.org/jira/browse/WICKET-4831
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Sebastien Briquet
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: patch
> Fix For: 6.3.0, 1.5.9
>
> Attachments: 0001-Updated-FeedbackPanel-added-getListCSSClass-getLabel.patch
>
>
> Hi,
> Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
> Both methods return #getCSSClass by default for backward compatibility.
> Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).
> The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.
> Best regards,
> Sebastien
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4831) Split custom CSS for Feedback
message (list and label)
Posted by "Sebastien Briquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastien Briquet updated WICKET-4831:
--------------------------------------
Attachment: 0001-Updated-FeedbackPanel-added-getListCSSClass-getLabel.patch
> Split custom CSS for Feedback message (list and label)
> ------------------------------------------------------
>
> Key: WICKET-4831
> URL: https://issues.apache.org/jira/browse/WICKET-4831
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Sebastien Briquet
> Priority: Minor
> Labels: patch
> Attachments: 0001-Updated-FeedbackPanel-added-getListCSSClass-getLabel.patch
>
>
> Hi,
> Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
> Both methods return #getCSSClass by default for backward compatibility.
> Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).
> The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.
> Best regards,
> Sebastien
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4831) Append the feedback message CSS
class instead of overriding it
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4831:
------------------------------------
Summary: Append the feedback message CSS class instead of overriding it (was: Split custom CSS for Feedback message (list and label))
> Append the feedback message CSS class instead of overriding it
> --------------------------------------------------------------
>
> Key: WICKET-4831
> URL: https://issues.apache.org/jira/browse/WICKET-4831
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Sebastien Briquet
> Priority: Minor
> Labels: patch
> Attachments: 0001-Updated-FeedbackPanel-added-getListCSSClass-getLabel.patch
>
>
> Hi,
> Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
> Both methods return #getCSSClass by default for backward compatibility.
> Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).
> The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.
> Best regards,
> Sebastien
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira