You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2019/07/12 13:00:59 UTC
Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use
relationship attribute
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71064/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
Diffs
-----
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 1825cd2
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 1765c18
Diff: https://reviews.apache.org/r/71064/diff/1/
Testing
-------
Steps done for updating
1. Disable hbsae-hook from Ambari.
2. Create table in hive.
3. Check whether table entity is created in Atlas side or not.(It should not be created)
4. Run script import-hbsae.sh
5. Check again in Atlas side, hive table and namespace entities are created with relationship.
Thanks,
Mandar Ambawane
Re: Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use
relationship attribute
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71064/#review216722
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On July 15, 2019, 11:17 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71064/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 11:17 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 6d062e2
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 4a4b4d9
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java a61a3e6
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java a74273a
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 6b050d4
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 4403aaf
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6ac176d
>
>
> Diff: https://reviews.apache.org/r/71064/diff/2/
>
>
> Testing
> -------
>
> Steps done for updating
> 1. Disable hbase-hook from Ambari.
> 2. Create table in hbase.
> 3. Check whether table entity is created in Atlas side or not.(It should not be created)
> 4. Run script import-hbsae.sh
> 5. Check again in Atlas side, hbase table and namespace entities are created with relationship.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use
relationship attribute
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71064/
-----------------------------------------------------------
(Updated July 15, 2019, 11:17 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
ATLAS-3326 Update Hbase hook/bridge to use relationship attribute and move conversion methods to class AtlasTypeUtil
Repository: atlas
Description
-------
ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
Diffs (updated)
-----
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 6d062e2
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 4a4b4d9
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java a61a3e6
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java a74273a
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 6b050d4
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 4403aaf
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6ac176d
Diff: https://reviews.apache.org/r/71064/diff/2/
Changes: https://reviews.apache.org/r/71064/diff/1-2/
Testing
-------
Steps done for updating
1. Disable hbase-hook from Ambari.
2. Create table in hbase.
3. Check whether table entity is created in Atlas side or not.(It should not be created)
4. Run script import-hbsae.sh
5. Check again in Atlas side, hbase table and namespace entities are created with relationship.
Thanks,
Mandar Ambawane
Re: Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use
relationship attribute
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71064/#review216579
-----------------------------------------------------------
Fix it, then Ship it!
rebase patch
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Line 226 (original), 226 (patched)
<https://reviews.apache.org/r/71064/#comment303787>
set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_column_families"
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Line 406 (original), 406 (patched)
<https://reviews.apache.org/r/71064/#comment303788>
set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_namespace"
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Line 465 (original), 465 (patched)
<https://reviews.apache.org/r/71064/#comment303790>
set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_column_families"
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
Line 425 (original), 425 (patched)
<https://reviews.apache.org/r/71064/#comment303792>
change cfIDs to AtlasRelatedObjectIds with relationship name - "hbase_table_column_families"
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
Line 542 (original), 542 (patched)
<https://reviews.apache.org/r/71064/#comment303793>
same here
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
Line 571 (original), 571 (patched)
<https://reviews.apache.org/r/71064/#comment303794>
update to related object id
- Sarath Subramanian
On July 12, 2019, 6 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71064/
> -----------------------------------------------------------
>
> (Updated July 12, 2019, 6 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
>
>
> Diffs
> -----
>
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 1825cd2
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 1765c18
>
>
> Diff: https://reviews.apache.org/r/71064/diff/1/
>
>
> Testing
> -------
>
> Steps done for updating
> 1. Disable hbase-hook from Ambari.
> 2. Create table in hbase.
> 3. Check whether table entity is created in Atlas side or not.(It should not be created)
> 4. Run script import-hbsae.sh
> 5. Check again in Atlas side, hbase table and namespace entities are created with relationship.
>
>
> Thanks,
>
> Mandar Ambawane
>
>