You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/05 09:42:17 UTC
[GitHub] [ignite] ivandasch opened a new pull request #9470: IGNITE-15678 CPP: Implement building windows installer of ODBC Driver on CMake
ivandasch opened a new pull request #9470:
URL: https://github.com/apache/ignite/pull/9470
… on CMake
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a change in pull request #9470: IGNITE-15678 CPP: Implement building windows installer of ODBC Driver on CMake
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #9470:
URL: https://github.com/apache/ignite/pull/9470#discussion_r722140890
##########
File path: modules/platforms/cpp/odbc/CMakeLists.txt
##########
@@ -102,6 +102,52 @@ else()
target_link_libraries(${TARGET} ignite-common ignite-binary ignite-network)
endif()
+if (WIN32)
+ set(WIX_ODBC_LIBRARY_PATH ".\\ignite.odbc.dll")
+
+ set(WIX_PROJECT_NAME "Apache Ignite")
+ set(WIX_MANUFACTURER "The Apache Software Foundation")
+ set(WIX_COPYRIGHT_COMMENT "Apache, Apache Ignite, the Apache feather and the Apache Ignite logo are trademarks of The Apache Software Foundation.")
+
+ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
+ set(WIX_BIT_SUFFIX "64-bit")
+ set(WIX_PRODUCT_ID "F3E308E4-910C-4AF5-82DE-2ACF4D64830E")
+ set(WIX_UPGRADE_CODE "1D7AEFDF-6CD2-4FB5-88F2-811A89832D6D")
+ set(WIX_COMPONENT_ID "E5F0DDF2-DD3C-4196-8A08-70921858A52F")
+ set(WIX_PROGRAM_FILES_FOLDER_ID "ProgramFiles64Folder")
+ set(WIX_COMPONENT_IS_WIN64 "yes")
+ set(WIX_PACKAGE_PLATFORM "x64")
+ set(WIX_INSTALLER_PREFIX ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/ignite-odbc-amd64)
+ elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
+ set(WIX_BIT_SUFFIX "32-bit")
+ set(WIX_PRODUCT_ID "D39CBABA-1E21-4701-AA5C-91EDA07B383B")
+ set(WIX_UPGRADE_CODE "743902A4-365C-424E-B226-5B2898A3941E")
+ set(WIX_COMPONENT_ID "4AFA26EE-C639-4EF2-A9B2-281119BB4BB5")
+ set(WIX_PROGRAM_FILES_FOLDER_ID "ProgramFilesFolder")
+ set(WIX_COMPONENT_IS_WIN64 "no")
+ set(WIX_PACKAGE_PLATFORM "x86")
+ set(WIX_INSTALLER_PREFIX ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/ignite-odbc-x86)
+ endif()
+
+ set(WIX_PRODUCT_NAME "${WIX_PROJECT_NAME} ODBC ${WIX_BIT_SUFFIX} Driver")
+
+ configure_file(
+ "${CMAKE_CURRENT_LIST_DIR}/install/ignite-odbc.wxs.in"
+ "${WIX_INSTALLER_PREFIX}.wxs"
+ @ONLY
+ )
+
+ add_custom_command(
+ TARGET ${TARGET} POST_BUILD
+ COMMAND candle ${WIX_INSTALLER_PREFIX}.wxs -out ${WIX_INSTALLER_PREFIX}.wxobj
+ COMMAND light -ext WixUIExtension ${WIX_INSTALLER_PREFIX}.wxobj -out ${WIX_INSTALLER_PREFIX}.msi
+ )
Review comment:
Will building of ODBC fail if user does not have WiX installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #9470: IGNITE-15678 CPP: Implement building windows installer of ODBC Driver on CMake
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #9470:
URL: https://github.com/apache/ignite/pull/9470#discussion_r722147775
##########
File path: modules/platforms/cpp/odbc/CMakeLists.txt
##########
@@ -102,6 +102,52 @@ else()
target_link_libraries(${TARGET} ignite-common ignite-binary ignite-network)
endif()
+if (WIN32)
+ set(WIX_ODBC_LIBRARY_PATH ".\\ignite.odbc.dll")
+
+ set(WIX_PROJECT_NAME "Apache Ignite")
+ set(WIX_MANUFACTURER "The Apache Software Foundation")
+ set(WIX_COPYRIGHT_COMMENT "Apache, Apache Ignite, the Apache feather and the Apache Ignite logo are trademarks of The Apache Software Foundation.")
+
+ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
+ set(WIX_BIT_SUFFIX "64-bit")
+ set(WIX_PRODUCT_ID "F3E308E4-910C-4AF5-82DE-2ACF4D64830E")
+ set(WIX_UPGRADE_CODE "1D7AEFDF-6CD2-4FB5-88F2-811A89832D6D")
+ set(WIX_COMPONENT_ID "E5F0DDF2-DD3C-4196-8A08-70921858A52F")
+ set(WIX_PROGRAM_FILES_FOLDER_ID "ProgramFiles64Folder")
+ set(WIX_COMPONENT_IS_WIN64 "yes")
+ set(WIX_PACKAGE_PLATFORM "x64")
+ set(WIX_INSTALLER_PREFIX ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/ignite-odbc-amd64)
+ elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
+ set(WIX_BIT_SUFFIX "32-bit")
+ set(WIX_PRODUCT_ID "D39CBABA-1E21-4701-AA5C-91EDA07B383B")
+ set(WIX_UPGRADE_CODE "743902A4-365C-424E-B226-5B2898A3941E")
+ set(WIX_COMPONENT_ID "4AFA26EE-C639-4EF2-A9B2-281119BB4BB5")
+ set(WIX_PROGRAM_FILES_FOLDER_ID "ProgramFilesFolder")
+ set(WIX_COMPONENT_IS_WIN64 "no")
+ set(WIX_PACKAGE_PLATFORM "x86")
+ set(WIX_INSTALLER_PREFIX ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/ignite-odbc-x86)
+ endif()
+
+ set(WIX_PRODUCT_NAME "${WIX_PROJECT_NAME} ODBC ${WIX_BIT_SUFFIX} Driver")
+
+ configure_file(
+ "${CMAKE_CURRENT_LIST_DIR}/install/ignite-odbc.wxs.in"
+ "${WIX_INSTALLER_PREFIX}.wxs"
+ @ONLY
+ )
+
+ add_custom_command(
+ TARGET ${TARGET} POST_BUILD
+ COMMAND candle ${WIX_INSTALLER_PREFIX}.wxs -out ${WIX_INSTALLER_PREFIX}.wxobj
+ COMMAND light -ext WixUIExtension ${WIX_INSTALLER_PREFIX}.wxobj -out ${WIX_INSTALLER_PREFIX}.msi
+ )
Review comment:
Igor, yep, I'will add optional flag for it, soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch closed pull request #9470: IGNITE-15678 CPP: Implement building windows installer of ODBC Driver on CMake
Posted by GitBox <gi...@apache.org>.
ivandasch closed pull request #9470:
URL: https://github.com/apache/ignite/pull/9470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org