You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "JunRuiLee (via GitHub)" <gi...@apache.org> on 2024/01/04 07:25:29 UTC
[PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
JunRuiLee opened a new pull request, #24026:
URL: https://github.com/apache/flink/pull/24026
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
[FLINK-33982][core] Introduce new config options for Batch Job Recovery
## Brief change log
Introduce new config options for Batch Job Recovery
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk closed pull request #24026: [FLINK-33982][core] Introduce new config options for Batch Job Recovery
URL: https://github.com/apache/flink/pull/24026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on PR #24026:
URL: https://github.com/apache/flink/pull/24026#issuecomment-2022702614
@zhuzhurk Thanks for your review, I've updated this pr accordingly, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24026:
URL: https://github.com/apache/flink/pull/24026#issuecomment-1876596371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "39c47e5dba0fa1422bd0710f4de96c43453ae3ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39c47e5dba0fa1422bd0710f4de96c43453ae3ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39c47e5dba0fa1422bd0710f4de96c43453ae3ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #24026:
URL: https://github.com/apache/flink/pull/24026#discussion_r1538557863
##########
flink-core/src/main/java/org/apache/flink/configuration/BatchExecutionOptions.java:
##########
@@ -148,6 +148,30 @@ public class BatchExecutionOptions {
.withDescription(
"Controls how long an detected slow node should be blocked for.");
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Boolean> JOB_RECOVERY_ENABLED =
+ key("execution.batch.job-recovery.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("A flag to enable or disable the job recovery.");
Review Comment:
Better to add more explanations for this feature. e.g. "If enabled, batch jobs can resume with previously generated intermediate results after job master restarts due to failures, thereby preserving the progress."
##########
flink-core/src/main/java/org/apache/flink/configuration/JobEventStoreOptions.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.annotation.docs.Documentation;
+
+import java.time.Duration;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/** Configuration options for the job events. */
+@PublicEvolving
+public class JobEventStoreOptions {
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<MemorySize> WRITE_BUFFER_SIZE =
+ key("job-event.store.write-buffer.size")
+ .memoryType()
+ .defaultValue(MemorySize.parse("1MB"))
+ .withDescription(
+ "The size of the write buffer of JobEventStore, "
+ + "the content will be flushed to external file system once it's full");
Review Comment:
JobEventStore, -> JobEventStore.
once it's full -> once the buffer is full
##########
flink-core/src/main/java/org/apache/flink/configuration/BatchExecutionOptions.java:
##########
@@ -148,6 +148,30 @@ public class BatchExecutionOptions {
.withDescription(
"Controls how long an detected slow node should be blocked for.");
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Boolean> JOB_RECOVERY_ENABLED =
+ key("execution.batch.job-recovery.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("A flag to enable or disable the job recovery.");
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Duration> JOB_RECOVERY_PREVIOUS_WORKER_RECOVERY_TIMEOUT =
+ key("execution.batch.job-recovery.previous-worker.recovery.timeout")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+ .withDescription(
+ "The timeout for a new job master to wait for the previous worker to reconnect.");
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Duration> JOB_RECOVERY_SNAPSHOT_MIN_PAUSE =
+ key("execution.batch.job-recovery.snapshot.min-pause")
+ .durationType()
+ .defaultValue(Duration.ofMinutes(3))
+ .withDescription(
+ "The minimal pause between snapshots. To avoid performance issues caused by too frequent snapshots. "
Review Comment:
-> The minimal pause between snapshots taken by operator coordinator or other components. It is used to avoid performance degradation due to excessive snapshot frequency.
##########
flink-core/src/main/java/org/apache/flink/configuration/JobEventStoreOptions.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.annotation.docs.Documentation;
+
+import java.time.Duration;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/** Configuration options for the job events. */
+@PublicEvolving
+public class JobEventStoreOptions {
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<MemorySize> WRITE_BUFFER_SIZE =
+ key("job-event.store.write-buffer.size")
+ .memoryType()
+ .defaultValue(MemorySize.parse("1MB"))
+ .withDescription(
+ "The size of the write buffer of JobEventStore, "
+ + "the content will be flushed to external file system once it's full");
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Duration> FLUSH_INTERVAL =
+ key("job-event.store.write-buffer.flush-interval")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(1))
+ .withDescription(
+ "The flush interval of write buffer of JobEventStore, over this time, "
Review Comment:
write buffer of JobEventStore, -> JobEventStore write buffers.
over this time, the content will be flushed to external file system. -> Buffer contents will be flushed to external file system regularly with regard to this value.
##########
flink-core/src/main/java/org/apache/flink/configuration/BatchExecutionOptions.java:
##########
@@ -148,6 +148,30 @@ public class BatchExecutionOptions {
.withDescription(
"Controls how long an detected slow node should be blocked for.");
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Boolean> JOB_RECOVERY_ENABLED =
+ key("execution.batch.job-recovery.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("A flag to enable or disable the job recovery.");
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Duration> JOB_RECOVERY_PREVIOUS_WORKER_RECOVERY_TIMEOUT =
+ key("execution.batch.job-recovery.previous-worker.recovery.timeout")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+ .withDescription(
+ "The timeout for a new job master to wait for the previous worker to reconnect.");
Review Comment:
More explanations: "A reconnected worker will transmit the details of its produced intermediate results to the new job master, enabling the job master to reuse these results."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33982][core] Introduce new config options for Batch Job Recovery [flink]
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on PR #24026:
URL: https://github.com/apache/flink/pull/24026#issuecomment-1876593019
@wanglijie95 @zhuzhurk could you help to review this pr? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org