svn commit: r1614685 - in /spamassassin/trunk: lib/Mail/SpamAssassin/Plugin/MIMEEval.pm rulesrc/sandbox/kmcgrail/20_bug_7063.cf

[km...@apache.org]

Author: kmcgrail
Date: Wed Jul 30 15:37:01 2014
New Revision: 1614685

URL: http://svn.apache.org/r1614685
Log:
Cleaned up documentation and removed rule name parameter that was not needed on the rule

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
    spamassassin/trunk/rulesrc/sandbox/kmcgrail/20_bug_7063.cf

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm?rev=1614685&r1=1614684&r2=1614685&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm Wed Jul 30 15:37:01 2014
@@ -70,8 +70,22 @@ sub are_more_high_bits_set {
   ($numlos <= $numhis && $numhis > 3);
 }
 
+=item has_check_for_ascii_text_illegal
+
+Adds capability check for "if can()" for has_check_for_ascii_text_illegal
+
+=cut
+
 sub has_check_for_ascii_text_illegal { 1 }
 
+=item check_for_ascii_text_illegal
+
+If a MIME part claims to be text/plain or text/plain;charset=us-ascii and the Content-Transfer-Encoding is 7bit (either explicitly or by default), then we should enforce the actual text being only TAB, NL, SPACE through TILDE, i.e. all 7bit characters excluding NO-WS-CTL (per RFC-2822).
+
+All mainstream MTA's get this right.
+
+=cut
+
 sub check_for_ascii_text_illegal {
   my ($self, $pms) = @_;
 

Modified: spamassassin/trunk/rulesrc/sandbox/kmcgrail/20_bug_7063.cf
URL: http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/kmcgrail/20_bug_7063.cf?rev=1614685&r1=1614684&r2=1614685&view=diff
==============================================================================
--- spamassassin/trunk/rulesrc/sandbox/kmcgrail/20_bug_7063.cf (original)
+++ spamassassin/trunk/rulesrc/sandbox/kmcgrail/20_bug_7063.cf Wed Jul 30 15:37:01 2014
@@ -25,7 +25,7 @@
 
 ifplugin Mail::SpamAssassin::Plugin::MIMEEval
   if can(Mail::SpamAssassin::Plugin::MIMEEval::has_check_for_ascii_text_illegal)
-    body     PP_MIME_FAKE_ASCII_TEXT  eval:check_for_ascii_text_illegal('mime_fake_ascii_text')
+    body     PP_MIME_FAKE_ASCII_TEXT  eval:check_for_ascii_text_illegal()
     describe PP_MIME_FAKE_ASCII_TEXT  MIME text/plain claims to be ASCII but isn't
     score    PP_MIME_FAKE_ASCII_TEXT  1.0
     tflags   PP_MIME_FAKE_ASCII_TEXT  publish