You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/19 07:06:17 UTC

[GitHub] [superset] villebro commented on pull request #15254: fix: feature flags typing

villebro commented on pull request #15254:
URL: https://github.com/apache/superset/pull/15254#issuecomment-973806470


   > LGTM. We also have `SCHEDULED_QUERIES` which is non-boolean:
   > 
   > https://github.com/apache/superset/blob/1ab36c94f308cd9d8b5b68ebd8e90a9902b2ac7c/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L37
   > 
   > 
   > https://github.com/apache/superset/blob/1ab36c94f308cd9d8b5b68ebd8e90a9902b2ac7c/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L55
   
   Thanks @betodealmeida , let's get that one fixed, too!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org