You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/05/11 07:37:49 UTC

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3759: [HOTFIX] Set default header for load data in legacy enviroment

ajantha-bhat commented on a change in pull request #3759:
URL: https://github.com/apache/carbondata/pull/3759#discussion_r422841866



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CommonLoadUtils.scala
##########
@@ -212,7 +212,7 @@ object CommonLoadUtils {
       options: Map[String, String]): util.Map[String, String] = {
     val tableProperties = table.getTableInfo.getFactTable.getTableProperties
     val optionsFinal = LoadOption.fillOptionWithDefaultValue(options.asJava)
-    //    EnvHelper.setDefaultHeader(sparkSession, optionsFinal)
+    EnvHelper.setDefaultHeader(SparkSQLUtil.getSparkSession, optionsFinal)

Review comment:
       please add a comment here that it is for legacy store. 
   
   All data load in new store success without this change. so I commented this. If there was a comment why this is required. I would have kept it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org