[impala] branch master updated: IMPALA-10576: Add refresh authorization to make a test case less flaky

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 2039746  IMPALA-10576: Add refresh authorization to make a test case less flaky
2039746 is described below

commit 2039746ebecaf75b416d46abb4201e19bcbb98d8
Author: Fang-Yu Rao <fa...@cloudera.com>
AuthorDate: Mon Mar 8 09:04:28 2021 -0800

    IMPALA-10576: Add refresh authorization to make a test case less flaky
    
    We found that a test case run in test_grant_revoke_with_role() that is
    used to verify a requesting user does not possess the necessary
    privilege to perform the GRANT operation could fail since the expected
    AuthorizationException is not returned after the query. Since the
    privilege of GRANT was revoked immediately before this test case, we
    suspect the authorization-related metadata has not been updated. To make
    this test case less flaky, in this patch we add a REFRESH AUTHORIZATION
    after the query that revoked the GRANT privilege from the requesting
    user.
    
    Testing:
     - Verified that this patch passes the core tests in an ASAN build.
    
    Change-Id: I7407bac0407e162ab5ba623505bd7ee49bdf3abf
    Reviewed-on: http://gerrit.cloudera.org:8080/17165
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 .../workloads/functional-query/queries/QueryTest/grant_revoke.test     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test b/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
index c5fbdae..191b1bd 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
@@ -619,7 +619,8 @@ User doesn't have permissions to grant role grant_revoke_test_NON_OWNER
 admin
 ---- QUERY
 # Revoke the GRANT OPTION and verify the user can no longer GRANT or REVOKE
-revoke grant option for all on database functional from grant_revoke_test_NON_OWNER
+revoke grant option for all on database functional from grant_revoke_test_NON_OWNER;
+refresh authorization;
 ====
 ---- USER
 non_owner