You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/08/05 14:34:18 UTC
[shardingsphere] branch master updated: Change oracle userClauses syntax (#27939)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new a8d7a315be4 Change oracle userClauses syntax (#27939)
a8d7a315be4 is described below
commit a8d7a315be4ec741ebb8a3919422d73076bb63fb
Author: niu niu <zi...@aliyun.com>
AuthorDate: Sat Aug 5 22:34:11 2023 +0800
Change oracle userClauses syntax (#27939)
---
.../sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4 | 2 +-
test/it/parser/src/main/resources/case/ddl/alter-diskgroup.xml | 1 +
test/it/parser/src/main/resources/sql/supported/ddl/alter-diskgroup.xml | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4 b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
index 4f480e2fb49..c2ab432b802 100644
--- a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
+++ b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
@@ -3061,7 +3061,7 @@ usergroupClauses
;
userClauses
- : (ADD USER SQ_ username SQ_ (COMMA_ SQ_ username SQ_)*
+ : (ADD USER username (COMMA_ username)*
| DROP USER SQ_ username SQ_ (COMMA_ SQ_ username SQ_)* (CASCADE)?
| REPLACE USER SQ_ username SQ_ WITH SQ_ username SQ_ (COMMA_ SQ_ username SQ_ WITH SQ_ username SQ_)*)
;
diff --git a/test/it/parser/src/main/resources/case/ddl/alter-diskgroup.xml b/test/it/parser/src/main/resources/case/ddl/alter-diskgroup.xml
index c2700ef0783..f9745ed67d4 100644
--- a/test/it/parser/src/main/resources/case/ddl/alter-diskgroup.xml
+++ b/test/it/parser/src/main/resources/case/ddl/alter-diskgroup.xml
@@ -52,4 +52,5 @@
<alter-diskgroup sql-case-id="alter_diskgroup_enable_volume" />
<alter-diskgroup sql-case-id="alter_diskgroup_all_disable_volume_all" />
<alter-diskgroup sql-case-id="alter_diskgroup_drop_volume" />
+ <alter-diskgroup sql-case-id="alter_diskgroup_data_add_user" />
</sql-parser-test-cases>
diff --git a/test/it/parser/src/main/resources/sql/supported/ddl/alter-diskgroup.xml b/test/it/parser/src/main/resources/sql/supported/ddl/alter-diskgroup.xml
index 714e364e96f..26bcca288f6 100644
--- a/test/it/parser/src/main/resources/sql/supported/ddl/alter-diskgroup.xml
+++ b/test/it/parser/src/main/resources/sql/supported/ddl/alter-diskgroup.xml
@@ -52,4 +52,5 @@
<sql-case id="alter_diskgroup_enable_volume" value="ALTER DISKGROUP data ENABLE VOLUME volume1" db-types="Oracle" />
<sql-case id="alter_diskgroup_all_disable_volume_all" value="ALTER DISKGROUP ALL DISABLE VOLUME ALL" db-types="Oracle" />
<sql-case id="alter_diskgroup_drop_volume" value="ALTER DISKGROUP data DROP VOLUME volume1" db-types="Oracle" />
+ <sql-case id="alter_diskgroup_data_add_user" value="ALTER DISKGROUP DATA ADD USER 'oracle1'" db-types="Oracle" />
</sql-cases>