You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/26 01:05:03 UTC
Review Request 37776: Setting revocable flag on a TaskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37776/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710
Diff: https://reviews.apache.org/r/37776/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37776: Setting revocable flag on a TaskInfo.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37776/#review96480
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Aug. 25, 2015, 4:05 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37776/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 4:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710
>
> Diff: https://reviews.apache.org/r/37776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37776: Setting revocable flag on a TaskInfo.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37776/#review96459
-----------------------------------------------------------
Ship it!
Master (96a086c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 25, 2015, 11:05 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37776/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 11:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710
>
> Diff: https://reviews.apache.org/r/37776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37776: Setting revocable flag on a TaskInfo.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37776/#review96566
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Aug. 25, 2015, 4:05 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37776/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 4:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710
>
> Diff: https://reviews.apache.org/r/37776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>