You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/09 16:27:36 UTC

[GitHub] [pulsar] mik-laj opened a new pull request #9159: [INFRA] Cancel the previous build

mik-laj opened a new pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159


   Master Issue: https://github.com/apache/pulsar/issues/9154
   
   ### Motivation
   
   This PR aims to reduce the GitHub Action usage by cancelling the previous build.
   
   ### Modifications
   
   Similar to: https://github.com/apache/spark/pull/31098 https://github.com/apache/calcite/pull/2318 (solution suggestted by @vlsi - https://github.com/apache/pulsar/issues/9154#issuecomment-756984731)
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757380717


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

lhotari commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-769242902


   Hi @potiuk @zymap @sijie,
   
   I have started a draft PIP (Pulsar Improvement Proposal) discussion on the dev@pulsar.apache.org mailing list to address the Github Actions Runner resource consumption issues that currently exist in the Pulsar Github Actions workflows:
   https://lists.apache.org/thread.html/ra2fcf7b973448bb51e00aceaeed06433e8d886270b0f0db0c80d4e0c%40%3Cdev.pulsar.apache.org%3E
   
   Please participate in the discussion on the dev@pulsar.apache.org mailing list or place comments / editing suggestions directly on the Google doc: 
   https://docs.google.com/document/d/1FNEWD3COdnNGMiryO9qBUW_83qtzAhqjDI5wwmPD-YE/edit?usp=sharing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-766915396

@eolivelli

I think the root cause is a bit different. Seems like your workflow/job pattern is different than many other ASF projects, you are simply launching MANY workflows and jobs.

Have you considered merging those workflows into smaller number of them ? I think actually the many, many workflows launched by pulsar are the reason for many ASF projects to get blocked queue.

See this chart:

![06a6b973-fee9-4651-a197-a275a39b6f55](https://user-images.githubusercontent.com/595491/105729417-7cfc2b00-5f2d-11eb-9da6-69c7b9d5904f.png)

I am happy to help Pulsar to redesign their CI to be a bit more friendlier towards other projects? I have quite an experience with that - in Apache Airflow I introduced changes that brought the usage of Github Actions by 70% maintaining it's usefulness and I am pretty sure the way you are using GitHub Actions can be optimised. Super Happy to help with that if needed.

You can also see the discussions we had about it at the ASF discussion lists recently. I thik this thread from the last weekend describes the current state of affairs rather well: https://lists.apache.org/thread.html/r6130d6d111217b8a90b3b90bbb3029b75b5e2a4b5463f8d2c8f130f6%40%3Cusers.infra.apache.org%3E (you need to sign-up to users@infra.apache.org to view it).

Do you think this can be done ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757409300


   I updated this PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-766915396

@eolivelli

I think the root cause is a bit different. Seems like your workflow/job pattern is different than many other ASF projects, you are simply launching MANY workflows and jobs.

Have you considered merging those workflows into smaller number of them ? I think actually the many, many workflows launched by pulsar are the reason for many ASF projects to get blocked queue.

See this chart:

![06a6b973-fee9-4651-a197-a275a39b6f55](https://user-images.githubusercontent.com/595491/105729417-7cfc2b00-5f2d-11eb-9da6-69c7b9d5904f.png)

Do you think this can be done ?

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757398875


   @codelipenghui  We want to support fork as well, so we have to use workflow_run, so this change will only take effect after merging.
   
   >  If you use forks, you should create a separate "Cancelling" workflow_run triggered workflow. The workflow_run should be responsible for all canceling actions. The examples below show the possible ways the action can be utilized.
   
   https://github.com/potiuk/cancel-workflow-runs#usage
   
   > Note: This event will only trigger a workflow run if the workflow file is on the default branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757394170


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757336104






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757380717






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-769330837


   I will take a look tomorrow. I'v been swamped by some company matters but tomorrow is the day I start going back to live :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on a change in pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#discussion_r554863971



##########
File path: .github/workflows/cancel-duplicates.yml
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Cancelling Duplicates
+on:
+  workflow_run:
+    workflows: 
+      - 'CI - Build - MacOS'

Review comment:
       The documentation is not very precise and does not describe whether this field is optional. I have not seen any examples that do not define it, so I think it is required. On the other hand, this event doesn't support the exclude list, so it seems to be the only way to exclude "PulsarBot".
   https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

zymap commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-767400127


   Hi @potiuk. In the beginning, Pulsar separates the tests into different workflows is for reducing the build and test time. We category with the different tests to make the tests can run parallel. If there has a specific workflow failed, we can re-run the failed workflow and don't need to re-run the entire project tests. 
   I saw the other apache projects use a single workflow to run the build and test, if Pulsar uses one workflow to run the build and test, that would take a long time to pass the CI.
   Do you have some suggestions? If you can help with improving the CI that would be nice!
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

sijie commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-767457397


   @zymap - I think we can consider running Pulsar CI in the Azure pipeline like Flink is doing. We can reach out to our Flink friends to see how they do it.
   
   Example: https://github.com/apache/flink/pull/14756#issuecomment-767326796
   
   https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=12498&view=results


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on a change in pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#discussion_r554448820



##########
File path: .github/cancel-duplicates.yaml
##########
@@ -0,0 +1,51 @@
+name: Cancelling Duplicates
+on:
+  workflow_run:
+    workflows: 
+      - 'CI - Build - MacOS'
+      - 'CI - CPP, Python Tests'
+      - 'CI - Go Functions style check'
+      - 'CI - Go Functions Tests'
+      - 'CI - Integration - Backwards Compatibility'
+      - 'CI - Integration - Cli'
+      - 'CI - Integration - Function State'
+      - 'CI - Integration - Messaging'
+      - 'CI - Integration - Process'
+      - 'CI - Integration - Schema'
+      - 'CI - Integration - Sql'
+      - 'CI - Integration - Standalone'
+      - 'CI - Integration - Thread'
+      - 'CI - Integration - Tiered FileSystem'
+      - 'CI - Integration - Tiered JCloud'
+      - 'CI - Integration - Transaction'
+      - 'CI - Misc'
+      - 'CI - Pulsar Website build'
+      - 'Pulsar Bot'

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757336104


   @vlsi @potiuk Can I ask for a review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757428532


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

eolivelli commented on a change in pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#discussion_r554855317



##########
File path: .github/workflows/cancel-duplicates.yml
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Cancelling Duplicates
+on:
+  workflow_run:
+    workflows: 
+      - 'CI - Build - MacOS'

Review comment:
       is it necessary to write here the list of jobs ?
   we can forget about it in the future




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

lhotari commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-769976936


   > I commented as much as I could and provided all the examples and code links from Apache Airflow :)
   
   Thank you @potiuk . Very helpful and informative comments with lots of good advice. I'll take a closer look next week when I continue working on the topic. Have a great weekend!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-769975337


   I commented as much as I could and provided all the examples and code links from Apache Airflow :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] vlsi commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

vlsi commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757331105


   `token` is a required parameter, so please add it (see https://github.com/apache/spark/pull/31104/files/817ed96403de8f791d61280eaa766a0e980fc865#diff-48c0ee97c53013d18d6bbae44648f7fab9af2e0bf5b0dc1ca761e18ec5c478f2 )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk commented on a change in pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#discussion_r554893485



##########
File path: .github/workflows/cancel-duplicates.yml
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Cancelling Duplicates
+on:
+  workflow_run:
+    workflows: 
+      - 'CI - Build - MacOS'

Review comment:
       Unfortunately I think this is the only way :( . What you can do is to make some pre-commit check to verify if the list is complete/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

eolivelli commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-767427730

> I am happy to help Pulsar to redesign their CI to be a bit more friendlier towards other projects? I have quite an experience with that - in Apache Airflow I introduced changes that brought the usage of Github Actions by 70% maintaining it's usefulness and I am pretty sure the way you are using GitHub Actions can be optimised. Super Happy to help with that if needed.

@potiuk any help is very appreciated
as @zymap says the problem is that we have lots of tests and they take much time.

We are working on fixing all of the flakes, but this will take time. This will help because we won't need to rerun PR validation more times than needed.

Probably it would be interesting to try to merge the workflows: all java tests, all integration tests, all cpp....in some test GitHub repository and work on a new setup.
We also should remove the 'retry' at build script level.

if we let the build continue in case of errors we should have some tool to gather all of the failures and we must be sure that we are not missing any of them

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757405175


   This action has been added to white-list. See: https://issues.apache.org/jira/browse/INFRA-21287
   I working on the update for this PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

eolivelli commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-766908097


   It looks like that this job is being triggered too many times.
   It is using many resources and for every workflow run we are adding many items to the queue 
   https://github.com/apache/pulsar/actions?page=4&query=is%3Aqueued
   
   I wonder if we can restore https://github.com/apache/pulsar/pull/8393
   
   cc @lhotari @sijie @mik-laj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

sijie merged pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] potiuk edited a comment on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-769330837


   I will take a look tomorrow. I'v been swamped by some company matters but tomorrow is the day I start going back to life :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] vlsi commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

vlsi commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-757331105


   `token` is a required parameter, so please add it (see https://github.com/apache/spark/pull/31104/files/817ed96403de8f791d61280eaa766a0e980fc865#diff-48c0ee97c53013d18d6bbae44648f7fab9af2e0bf5b0dc1ca761e18ec5c478f2 )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mik-laj commented on a change in pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#discussion_r554448820



##########
File path: .github/cancel-duplicates.yaml
##########
@@ -0,0 +1,51 @@
+name: Cancelling Duplicates
+on:
+  workflow_run:
+    workflows: 
+      - 'CI - Build - MacOS'
+      - 'CI - CPP, Python Tests'
+      - 'CI - Go Functions style check'
+      - 'CI - Go Functions Tests'
+      - 'CI - Integration - Backwards Compatibility'
+      - 'CI - Integration - Cli'
+      - 'CI - Integration - Function State'
+      - 'CI - Integration - Messaging'
+      - 'CI - Integration - Process'
+      - 'CI - Integration - Schema'
+      - 'CI - Integration - Sql'
+      - 'CI - Integration - Standalone'
+      - 'CI - Integration - Thread'
+      - 'CI - Integration - Tiered FileSystem'
+      - 'CI - Integration - Tiered JCloud'
+      - 'CI - Integration - Transaction'
+      - 'CI - Misc'
+      - 'CI - Pulsar Website build'
+      - 'Pulsar Bot'

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9159: [INFRA] Cancel the previous build

Posted by GitBox <gi...@apache.org>.

eolivelli commented on pull request #9159:
URL: https://github.com/apache/pulsar/pull/9159#issuecomment-766908097


   It looks like that this job is being triggered too many times.
   It is using many resources and for every workflow run we are adding many items to the queue 
   https://github.com/apache/pulsar/actions?page=4&query=is%3Aqueued
   
   I wonder if we can restore https://github.com/apache/pulsar/pull/8393
   
   cc @lhotari @sijie @mik-laj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org