[GitHub] [cloudstack] shwstppr commented on a change in pull request #5320: server: use id column as secondary sort criteria with sortKey

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5320:
URL: https://github.com/apache/cloudstack/pull/5320#discussion_r690328369



##########
File path: framework/db/src/main/java/com/cloud/utils/db/Filter.java
##########
@@ -77,7 +77,9 @@ public void addOrderBy(Class<?> clazz, String field, boolean ascending) {
 
         Column column = f.getAnnotation(Column.class);
         String name = column != null ? column.name() : field;
-
+        if (!name.equals("id")) {
+            name = String.format("%s, id", name);

Review comment:
       @rhtyd changed the logic. No changes in Filter class now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org