[GitHub] [solr] madrob commented on a change in pull request #477: SOLR-15876 Update to error-prone 2.10

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #477:
URL: https://github.com/apache/solr/pull/477#discussion_r774796548



##########
File path: solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java
##########
@@ -262,33 +259,6 @@ private void updateForFire(WatchedEvent event) {
       }
     }
 
-    private class TestServerCnxn extends NIOServerCnxn {
-
-      private final WatchLimiter limiter;
-
-      public TestServerCnxn(ZooKeeperServer zk, SocketChannel sock, SelectionKey sk,
-                            NIOServerCnxnFactory factory, WatchLimiter limiter) throws IOException {
-        super(zk, sock, sk, factory, null);
-        this.limiter = limiter;
-      }
-
-      @Override
-      public synchronized void process(WatchedEvent event) {
-        limiter.updateForFire(event);
-        super.process(event);
-      }
-    }
-
-    private class TestServerCnxnFactory extends NIOServerCnxnFactory {

Review comment:
       This class didn't do anything.

##########
File path: solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java
##########
@@ -262,33 +259,6 @@ private void updateForFire(WatchedEvent event) {
       }
     }
 
-    private class TestServerCnxn extends NIOServerCnxn {

Review comment:
       This class was unused.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org