You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/10/23 20:44:59 UTC

Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.


Bugs: AMBARI-13548
    https://issues.apache.org/jira/browse/AMBARI-13548


Repository: ambari


Description
-------

NameNode start command is failing in this call,
```
# Always run this on non-HA, or active NameNode during HA.
create_hdfs_directories(is_active_namenode_cmd)
```

It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.


For the NonRolling Upgrade Packs, change the title of the groups,
Rename the high-level and low-level to be this…
- Stop Components for High-Level Services
- Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)

Rename these others…
- Zookeeper => ZooKeeper
- MR and YARN => YARN and MapReduce2
- Take Backups =>Perform Backups
- Update Desired Stack Id => Update Target Stack


Diffs
-----

  ambari-common/src/main/python/resource_management/core/environment.py 134f164 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 

Diff: https://reviews.apache.org/r/39607/diff/


Testing
-------


Thanks,

Alejandro Fernandez


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Oct. 23, 2015, 8:21 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py, line 98
> > <https://reviews.apache.org/r/39607/diff/2/?file=1105199#file1105199line98>
> >
> >     Why not support only_if=None instead? There could be other places were we might have been using only_if=None that might have been broken too. Just that we havent caught them.

I couldn't find what led to this. Having only_if=None seems odd to begin with.
I searched the code base and only HDFS was setting only_if=None, so I believe this is fixed.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/#review103844
-----------------------------------------------------------


On Oct. 23, 2015, 7 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39607/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 7 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.
> 
> 
> Bugs: AMBARI-13548
>     https://issues.apache.org/jira/browse/AMBARI-13548
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NameNode start command is failing in this call,
> ```
> # Always run this on non-HA, or active NameNode during HA.
> create_hdfs_directories(is_active_namenode_cmd)
> ```
> 
> It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.
> 
> 
> For the NonRolling Upgrade Packs, change the title of the groups,
> Rename the high-level and low-level to be this…
> - Stop Components for High-Level Services
> - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)
> 
> Rename these others…
> - Zookeeper => ZooKeeper
> - MR and YARN => YARN and MapReduce2
> - Take Backups =>Perform Backups
> - Update Desired Stack Id => Update Target Stack
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/environment.py 134f164 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 
> 
> Diff: https://reviews.apache.org/r/39607/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:818
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/#review103844
-----------------------------------------------------------



ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py (line 98)
<https://reviews.apache.org/r/39607/#comment161940>

    Why not support only_if=None instead? There could be other places were we might have been using only_if=None that might have been broken too. Just that we havent caught them.


- Jayush Luniya


On Oct. 23, 2015, 7 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39607/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 7 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.
> 
> 
> Bugs: AMBARI-13548
>     https://issues.apache.org/jira/browse/AMBARI-13548
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NameNode start command is failing in this call,
> ```
> # Always run this on non-HA, or active NameNode during HA.
> create_hdfs_directories(is_active_namenode_cmd)
> ```
> 
> It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.
> 
> 
> For the NonRolling Upgrade Packs, change the title of the groups,
> Rename the high-level and low-level to be this…
> - Stop Components for High-Level Services
> - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)
> 
> Rename these others…
> - Zookeeper => ZooKeeper
> - MR and YARN => YARN and MapReduce2
> - Take Backups =>Perform Backups
> - Update Desired Stack Id => Update Target Stack
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/environment.py 134f164 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 
> 
> Diff: https://reviews.apache.org/r/39607/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:818
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/#review103857
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 49)
<https://reviews.apache.org/r/39607/#comment161959>

    Avoid using Daemons keyword. STOP_HIGH_LEVEL_SERVICE_COMPONENTS


- Jayush Luniya


On Oct. 23, 2015, 7 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39607/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 7 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.
> 
> 
> Bugs: AMBARI-13548
>     https://issues.apache.org/jira/browse/AMBARI-13548
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NameNode start command is failing in this call,
> ```
> # Always run this on non-HA, or active NameNode during HA.
> create_hdfs_directories(is_active_namenode_cmd)
> ```
> 
> It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.
> 
> 
> For the NonRolling Upgrade Packs, change the title of the groups,
> Rename the high-level and low-level to be this…
> - Stop Components for High-Level Services
> - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)
> 
> Rename these others…
> - Zookeeper => ZooKeeper
> - MR and YARN => YARN and MapReduce2
> - Take Backups =>Perform Backups
> - Update Desired Stack Id => Update Target Stack
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/environment.py 134f164 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 
> 
> Diff: https://reviews.apache.org/r/39607/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:818
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 9:14 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.


Changes
-------

Addressed comments


Bugs: AMBARI-13548
    https://issues.apache.org/jira/browse/AMBARI-13548


Repository: ambari


Description
-------

NameNode start command is failing in this call,
```
# Always run this on non-HA, or active NameNode during HA.
create_hdfs_directories(is_active_namenode_cmd)
```

It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.


For the NonRolling Upgrade Packs, change the title of the groups,
Rename the high-level and low-level to be this…
- Stop Components for High-Level Services
- Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)

Rename these others…
- Zookeeper => ZooKeeper
- MR and YARN => YARN and MapReduce2
- Take Backups =>Perform Backups
- Update Desired Stack Id => Update Target Stack


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/environment.py 134f164 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 

Diff: https://reviews.apache.org/r/39607/diff/


Testing
-------

----------------------------------------------------------------------
Total run:818
Total errors:0
Total failures:0


Thanks,

Alejandro Fernandez


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/#review103854
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 49)
<https://reviews.apache.org/r/39607/#comment161957>

    Names on <group> elements aren't meant to be descriptive - can use a string that's "like" a constant:  STOP_HIGH_LEVEL_DAEMONS


- Nate Cole


On Oct. 23, 2015, 3 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39607/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 3 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.
> 
> 
> Bugs: AMBARI-13548
>     https://issues.apache.org/jira/browse/AMBARI-13548
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NameNode start command is failing in this call,
> ```
> # Always run this on non-HA, or active NameNode during HA.
> create_hdfs_directories(is_active_namenode_cmd)
> ```
> 
> It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.
> 
> 
> For the NonRolling Upgrade Packs, change the title of the groups,
> Rename the high-level and low-level to be this…
> - Stop Components for High-Level Services
> - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)
> 
> Rename these others…
> - Zookeeper => ZooKeeper
> - MR and YARN => YARN and MapReduce2
> - Take Backups =>Perform Backups
> - Update Desired Stack Id => Update Target Stack
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/environment.py 134f164 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 
> 
> Diff: https://reviews.apache.org/r/39607/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:818
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/#review103866
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Oct. 23, 2015, 7 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39607/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 7 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.
> 
> 
> Bugs: AMBARI-13548
>     https://issues.apache.org/jira/browse/AMBARI-13548
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NameNode start command is failing in this call,
> ```
> # Always run this on non-HA, or active NameNode during HA.
> create_hdfs_directories(is_active_namenode_cmd)
> ```
> 
> It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.
> 
> 
> For the NonRolling Upgrade Packs, change the title of the groups,
> Rename the high-level and low-level to be this…
> - Stop Components for High-Level Services
> - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)
> 
> Rename these others…
> - Zookeeper => ZooKeeper
> - MR and YARN => YARN and MapReduce2
> - Take Backups =>Perform Backups
> - Update Desired Stack Id => Update Target Stack
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/environment.py 134f164 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 
> 
> Diff: https://reviews.apache.org/r/39607/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:818
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 7 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.


Bugs: AMBARI-13548
    https://issues.apache.org/jira/browse/AMBARI-13548


Repository: ambari


Description
-------

NameNode start command is failing in this call,
```
# Always run this on non-HA, or active NameNode during HA.
create_hdfs_directories(is_active_namenode_cmd)
```

It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.


For the NonRolling Upgrade Packs, change the title of the groups,
Rename the high-level and low-level to be this…
- Stop Components for High-Level Services
- Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)

Rename these others…
- Zookeeper => ZooKeeper
- MR and YARN => YARN and MapReduce2
- Take Backups =>Perform Backups
- Update Desired Stack Id => Update Target Stack


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/environment.py 134f164 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c 

Diff: https://reviews.apache.org/r/39607/diff/


Testing
-------

----------------------------------------------------------------------
Total run:818
Total errors:0
Total failures:0


Thanks,

Alejandro Fernandez


Re: Review Request 39607: Stop-and-Start Upgrade: NameNode restart fails since HdfsResource only_if condition not working, change title of Groups

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39607/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 6:59 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Xi Wang.


Bugs: AMBARI-13548
    https://issues.apache.org/jira/browse/AMBARI-13548


Repository: ambari


Description
-------

NameNode start command is failing in this call,
```
# Always run this on non-HA, or active NameNode during HA.
create_hdfs_directories(is_active_namenode_cmd)
```

It appears that the HdfsResource call no longer skips the task when the only_if condition is set to None.


For the NonRolling Upgrade Packs, change the title of the groups,
Rename the high-level and low-level to be this…
- Stop Components for High-Level Services
- Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger)

Rename these others…
- Zookeeper => ZooKeeper
- MR and YARN => YARN and MapReduce2
- Take Backups =>Perform Backups
- Update Desired Stack Id => Update Target Stack


Diffs
-----

  ambari-common/src/main/python/resource_management/core/environment.py 134f164 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 98b8afd 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a71c379 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 5aacfa0 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9997c12 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e92a413 

Diff: https://reviews.apache.org/r/39607/diff/


Testing (updated)
-------

----------------------------------------------------------------------
Total run:818
Total errors:0
Total failures:0


Thanks,

Alejandro Fernandez