You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2017/04/28 15:10:14 UTC
Review Request 58845: AMBARI-20891 - Allow extensions to auto-link
with supported stack versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
Bugs: AMBARI-20891
https://issues.apache.org/jira/browse/AMBARI-20891
Repository: ambari
Description
-------
It would possible to link extensions to supported stack versions while parsing the stacks, extensions and common-services directories.
This would allow extensions to avoid making rest API calls to set up the link.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce08
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java 3df1cd5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java 12b3ce0
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java ce92ecf
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 20e28fc
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java d3ad351
ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 656a8ce
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java 77a7250
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java 9900eb5
ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c
ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c
ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/58845/diff/1/
Testing
-------
mvn clean test
mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
Thanks,
Tim Thorpe
Re: Review Request 58845: AMBARI-20891 - Allow extensions to
auto-link with supported stack versions
Posted by Tim Thorpe <tt...@ca.ibm.com>.
> On April 28, 2017, 5:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Line 5456 (original), 5457 (patched)
> > <https://reviews.apache.org/r/58845/diff/1/?file=1703101#file1703101line5461>
> >
> > Please include Jonathan Hurley, Nate Cole, and Jayush Luniya in this review.
Added Jonathan and Nate. Jayush was already added.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173348
-----------------------------------------------------------
On April 28, 2017, 5:48 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 5:48 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It would possible to link extensions to supported stack versions while parsing the stacks, extensions and common-services directories.
>
> This would allow extensions to avoid making rest API calls to set up the link.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce08
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java 3df1cd5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java 12b3ce0
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java ce92ecf
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 20e28fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java d3ad351
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 656a8ce
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java 77a7250
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java 9900eb5
> ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c
> ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c
> ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58845/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
>
>
> Thanks,
>
> Tim Thorpe
>
>
Re: Review Request 58845: AMBARI-20891 - Allow extensions to
auto-link with supported stack versions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173348
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 5456 (original), 5457 (patched)
<https://reviews.apache.org/r/58845/#comment246369>
Please include Jonathan Hurley, Nate Cole, and Jayush Luniya in this review.
- Alejandro Fernandez
On April 28, 2017, 3:10 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 3:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
>
>
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It would possible to link extensions to supported stack versions while parsing the stacks, extensions and common-services directories.
>
> This would allow extensions to avoid making rest API calls to set up the link.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce08
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java 3df1cd5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java 12b3ce0
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java ce92ecf
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 20e28fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java d3ad351
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 656a8ce
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java 77a7250
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java 9900eb5
> ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c
> ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c
> ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58845/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
>
>
> Thanks,
>
> Tim Thorpe
>
>
Re: Review Request 58845: AMBARI-20891 - Allow extensions to
auto-link with supported stack versions
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173336
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On April 28, 2017, 3:10 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 3:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
>
>
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It would possible to link extensions to supported stack versions while parsing the stacks, extensions and common-services directories.
>
> This would allow extensions to avoid making rest API calls to set up the link.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce08
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java 3df1cd5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java 12b3ce0
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java ce92ecf
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 20e28fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java d3ad351
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 656a8ce
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java 77a7250
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java 9900eb5
> ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c
> ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c
> ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58845/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
>
>
> Thanks,
>
> Tim Thorpe
>
>