You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/14 05:59:32 UTC
[GitHub] [incubator-mxnet] rondogency opened a new pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
rondogency opened a new pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706
This reverts commit b523527df2aee4caa9275f9f1fa1668d5ae27cd6.
This is a continuation of 1.7 revert of the same PR: https://github.com/apache/incubator-mxnet/pull/18692
Since CD is built on top of 1.x, we should also unblock CD on top of 1.7 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-666574683
I think when enabling the branch protection, we accidentally turned on "Require branches to be up to date before merging". I'm requesting to disable it in https://issues.apache.org/jira/browse/INFRA-20616. Don't worry about updating the branch in this PR for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] rondogency closed pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
rondogency closed pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-659202436
The issue does not apply to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] rondogency commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
rondogency commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-660240557
@mxnet-bot run ci [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-659127449
@leezu are you patching it in master? That way @rondogency can pick it up here and validate 1.x again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-657984915
Hey @rondogency , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, windows-gpu, unix-cpu, unix-gpu, windows-cpu, centos-gpu, website, sanity, edge, clang, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-659214645
Oh right, I just realized that _BlockScope is gone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18706: [1.x] Revert Fix memory leaks in Gluon in 1.x branch
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18706:
URL: https://github.com/apache/incubator-mxnet/pull/18706#issuecomment-660240587
Jenkins CI successfully triggered : [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org