You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "philipnee (via GitHub)" <gi...@apache.org> on 2023/02/16 02:04:37 UTC

[GitHub] [kafka] philipnee commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

philipnee commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107930541


##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1249,7 +1263,7 @@ private ConsumerRecords<K, V> poll(final Timer timer, final boolean includeMetad
                     //
                     // NOTE: since the consumed position has already been updated, we must not allow

Review Comment:
   This is an old documentation, I wonder if it can be a bit misleading as we don't really have a consumed position anymore. @hachikuji 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org