You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/21 23:33:07 UTC
[GitHub] [airflow] Taragolis commented on a diff in pull request #26579: Fix bad test for unknown hook type
Taragolis commented on code in PR #26579:
URL: https://github.com/apache/airflow/pull/26579#discussion_r977063422
##########
tests/providers/common/sql/operators/test_sql.py:
##########
@@ -226,7 +226,7 @@ def test_get_hook(self, mock_get_conn, database):
def test_not_allowed_conn_type(self, mock_get_conn):
mock_get_conn.return_value = Connection(conn_id='sql_default', conn_type='s3')
- with pytest.raises(AirflowException, match=r"You are trying to use `common-sql`"):
+ with pytest.raises(AirflowException, match=r'Unknown hook type "s3"'):
Review Comment:
I thought better replace conn_type from `s3`, which not exists anymore to existed conn_type like `aws`, `google_cloud_platform`, `http` so we won't change actual test - provide use unsupported Hook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org