[GitHub] [zookeeper] eolivelli commented on a change in pull request #1736: [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1736:
URL: https://github.com/apache/zookeeper/pull/1736#discussion_r684650070



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
##########
@@ -3031,6 +3031,13 @@ private ClientCnxnSocket getClientCnxnSocket() throws IOException {
         if (clientCnxnSocketName == null) {
             clientCnxnSocketName = ClientCnxnSocketNIO.class.getName();
         }
+
+        if (clientCnxnSocketName.equals(ClientCnxnSocketNetty.class.getSimpleName())) {

Review comment:
       Why are you using getSimpleName ?
   
   Can you please explain how did you test this patch ?
   I am not sure it is worth to add an integration test but we should verify that this works well.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org