You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Xin Wang <xi...@gmail.com> on 2018/12/19 12:23:00 UTC

Re: The issues of [Enhance the test coverage] project are here waiting for you

Hi all
        It's been a long time since I started this project. I am very
pleased to announce that the test coverage of Dubbo is now 64%.
We have achieved the goal of stage 1: unit test coverage > 60%.

A lot of people submitted prs, the contributors and the number of their prs
are as follows:

   YunKun Huang (@htynkn)                 5
   Ian Luo (@beiwei30)                         3
   Kimm King (@kimming)                       2
   Xin Wang (@lovepoem)                 1
   Zonghai Shang (@zonghaishang) 1
   Song Kun   (@satansk)                        1
   xialongfei (@stoneapple)                     1
   钟剑 (@DeadLion)                                1
   Yang Tao        (@whanice)                   1
   Qin Yulin (@qinnnyul)                          1
   Yong Zhu (diecui1202)                         1

   Thank you very much for your contribution.
Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
then the project will be completed. If anybody want to take part in, please
leave a message on these issues?
Thank you !

[1] https://github.com/apache/incubator-dubbo/issues/1690
[2] https://github.com/apache/incubator-dubbo/issues/1692

Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:

> Hi,all
>       In order to enhance the test coverage, now the project is started:
> https://github.com/apache/incubator-dubbo/projects/1,
> you can also see the related issues in the other entrance page:
> https://github.com/apache/incubator-dubbo/issues/1702
>       The test coverage guide is here:
> https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
>
>       Welcome everyone to join in,you can comment on the issue that you're
> interest with.
>
> Xin Wang
> lovepoem@hotmail.com
>
>
>
>

Re: The issues of [Enhance the test coverage] project are here waiting for you

Posted by Mark Thomas <ma...@apache.org>.
On 19/12/2018 12:23, Xin Wang wrote:
> Hi all
>          It's been a long time since I started this project. I am very
> pleased to announce that the test coverage of Dubbo is now 64%.
> We have achieved the goal of stage 1: unit test coverage > 60%.

Congratulations to all involved. Great work.

Mark


> 
> A lot of people submitted prs, the contributors and the number of their prs
> are as follows:
> 
>     YunKun Huang (@htynkn)                 5
>     Ian Luo (@beiwei30)                         3
>     Kimm King (@kimming)                       2
>     Xin Wang (@lovepoem)                 1
>     Zonghai Shang (@zonghaishang) 1
>     Song Kun   (@satansk)                        1
>     xialongfei (@stoneapple)                     1
>     钟剑 (@DeadLion)                                1
>     Yang Tao        (@whanice)                   1
>     Qin Yulin (@qinnnyul)                          1
>     Yong Zhu (diecui1202)                         1
> 
>     Thank you very much for your contribution.
> Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
> then the project will be completed. If anybody want to take part in, please
> leave a message on these issues?
> Thank you !
> 
> [1] https://github.com/apache/incubator-dubbo/issues/1690
> [2] https://github.com/apache/incubator-dubbo/issues/1692
> 
> Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:
> 
>> Hi,all
>>        In order to enhance the test coverage, now the project is started:
>> https://github.com/apache/incubator-dubbo/projects/1,
>> you can also see the related issues in the other entrance page:
>> https://github.com/apache/incubator-dubbo/issues/1702
>>        The test coverage guide is here:
>> https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
>>
>>        Welcome everyone to join in,you can comment on the issue that you're
>> interest with.
>>
>> Xin Wang
>> lovepoem@hotmail.com
>>
>>
>>
>>
> 

Re: The issues of [Enhance the test coverage] project are here waiting for you

Posted by yuhang xiu <ca...@gmail.com>.
It’s great.

It seems that we have reached the goal and I agree to close the project.

Xin Wang <xi...@gmail.com> 于2018年12月19日周三 下午8:23写道:

> Hi all
>         It's been a long time since I started this project. I am very
> pleased to announce that the test coverage of Dubbo is now 64%.
> We have achieved the goal of stage 1: unit test coverage > 60%.
>
> A lot of people submitted prs, the contributors and the number of their prs
> are as follows:
>
>    YunKun Huang (@htynkn)                 5
>    Ian Luo (@beiwei30)                         3
>    Kimm King (@kimming)                       2
>    Xin Wang (@lovepoem)                 1
>    Zonghai Shang (@zonghaishang) 1
>    Song Kun   (@satansk)                        1
>    xialongfei (@stoneapple)                     1
>    钟剑 (@DeadLion)                                1
>    Yang Tao        (@whanice)                   1
>    Qin Yulin (@qinnnyul)                          1
>    Yong Zhu (diecui1202)                         1
>
>    Thank you very much for your contribution.
> Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
> then the project will be completed. If anybody want to take part in, please
> leave a message on these issues?
> Thank you !
>
> [1] https://github.com/apache/incubator-dubbo/issues/1690
> [2] https://github.com/apache/incubator-dubbo/issues/1692
>
> Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:
>
> > Hi,all
> >       In order to enhance the test coverage, now the project is started:
> > https://github.com/apache/incubator-dubbo/projects/1,
> > you can also see the related issues in the other entrance page:
> > https://github.com/apache/incubator-dubbo/issues/1702
> >       The test coverage guide is here:
> > https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
> >
> >       Welcome everyone to join in,you can comment on the issue that
> you're
> > interest with.
> >
> > Xin Wang
> > lovepoem@hotmail.com
> >
> >
> >
> >
>

Re: The issues of [Enhance the test coverage] project are here waiting for you

Posted by Xin Wang <xi...@gmail.com>.
> Is there phase 2 in the future? IMO, 60% code coverage is already very
good, but we can definitely do more than that!

I think we can plan the phase 2 of unit test: for example, 80% coverage of
unit test ?

Second, how to start integration test?


>BTW, I found that the new feature recently introduced by Github,
called pinned issue, is really helpful to highlight project like this
and attract more users to participate.

Yes , "pinned issue" is very useful  !

Huxing Zhang <hu...@apache.org> 于2018年12月20日周四 上午9:42写道:

> Good job!
>
> Is there phase 2 in the future? IMO, 60% code coverage is already very
> good, but we can definitely do more than that!
>
> BTW, I found that the new feature recently introduced by Github,
> called pinned issue, is really helpful to highlight project like this
> and attract more users to participate.
>
> On Wed, Dec 19, 2018 at 8:59 PM Ian Luo <ia...@gmail.com> wrote:
> >
> > Nice job, +1 to close this project. And Xin, thank you very much for
> > initing and leading this effort.
> >
> > -Ian.
> >
> > On Wed, Dec 19, 2018 at 8:23 PM Xin Wang <xi...@gmail.com>
> wrote:
> >
> > > Hi all
> > >         It's been a long time since I started this project. I am very
> > > pleased to announce that the test coverage of Dubbo is now 64%.
> > > We have achieved the goal of stage 1: unit test coverage > 60%.
> > >
> > > A lot of people submitted prs, the contributors and the number of
> their prs
> > > are as follows:
> > >
> > >    YunKun Huang (@htynkn)                 5
> > >    Ian Luo (@beiwei30)                         3
> > >    Kimm King (@kimming)                       2
> > >    Xin Wang (@lovepoem)                 1
> > >    Zonghai Shang (@zonghaishang) 1
> > >    Song Kun   (@satansk)                        1
> > >    xialongfei (@stoneapple)                     1
> > >    钟剑 (@DeadLion)                                1
> > >    Yang Tao        (@whanice)                   1
> > >    Qin Yulin (@qinnnyul)                          1
> > >    Yong Zhu (diecui1202)                         1
> > >
> > >    Thank you very much for your contribution.
> > > Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left
> , and
> > > then the project will be completed. If anybody want to take part in,
> please
> > > leave a message on these issues?
> > > Thank you !
> > >
> > > [1] https://github.com/apache/incubator-dubbo/issues/1690
> > > [2] https://github.com/apache/incubator-dubbo/issues/1692
> > >
> > > Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:
> > >
> > > > Hi,all
> > > >       In order to enhance the test coverage, now the project is
> started:
> > > > https://github.com/apache/incubator-dubbo/projects/1,
> > > > you can also see the related issues in the other entrance page:
> > > > https://github.com/apache/incubator-dubbo/issues/1702
> > > >       The test coverage guide is here:
> > > > https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
> > > >
> > > >       Welcome everyone to join in,you can comment on the issue that
> > > you're
> > > > interest with.
> > > >
> > > > Xin Wang
> > > > lovepoem@hotmail.com
> > > >
> > > >
> > > >
> > > >
> > >
>
>
>
> --
> Best Regards!
> Huxing
>

Re: The issues of [Enhance the test coverage] project are here waiting for you

Posted by Huxing Zhang <hu...@apache.org>.
Good job!

Is there phase 2 in the future? IMO, 60% code coverage is already very
good, but we can definitely do more than that!

BTW, I found that the new feature recently introduced by Github,
called pinned issue, is really helpful to highlight project like this
and attract more users to participate.

On Wed, Dec 19, 2018 at 8:59 PM Ian Luo <ia...@gmail.com> wrote:
>
> Nice job, +1 to close this project. And Xin, thank you very much for
> initing and leading this effort.
>
> -Ian.
>
> On Wed, Dec 19, 2018 at 8:23 PM Xin Wang <xi...@gmail.com> wrote:
>
> > Hi all
> >         It's been a long time since I started this project. I am very
> > pleased to announce that the test coverage of Dubbo is now 64%.
> > We have achieved the goal of stage 1: unit test coverage > 60%.
> >
> > A lot of people submitted prs, the contributors and the number of their prs
> > are as follows:
> >
> >    YunKun Huang (@htynkn)                 5
> >    Ian Luo (@beiwei30)                         3
> >    Kimm King (@kimming)                       2
> >    Xin Wang (@lovepoem)                 1
> >    Zonghai Shang (@zonghaishang) 1
> >    Song Kun   (@satansk)                        1
> >    xialongfei (@stoneapple)                     1
> >    钟剑 (@DeadLion)                                1
> >    Yang Tao        (@whanice)                   1
> >    Qin Yulin (@qinnnyul)                          1
> >    Yong Zhu (diecui1202)                         1
> >
> >    Thank you very much for your contribution.
> > Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
> > then the project will be completed. If anybody want to take part in, please
> > leave a message on these issues?
> > Thank you !
> >
> > [1] https://github.com/apache/incubator-dubbo/issues/1690
> > [2] https://github.com/apache/incubator-dubbo/issues/1692
> >
> > Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:
> >
> > > Hi,all
> > >       In order to enhance the test coverage, now the project is started:
> > > https://github.com/apache/incubator-dubbo/projects/1,
> > > you can also see the related issues in the other entrance page:
> > > https://github.com/apache/incubator-dubbo/issues/1702
> > >       The test coverage guide is here:
> > > https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
> > >
> > >       Welcome everyone to join in,you can comment on the issue that
> > you're
> > > interest with.
> > >
> > > Xin Wang
> > > lovepoem@hotmail.com
> > >
> > >
> > >
> > >
> >



-- 
Best Regards!
Huxing

Re: The issues of [Enhance the test coverage] project are here waiting for you

Posted by Ian Luo <ia...@gmail.com>.
Nice job, +1 to close this project. And Xin, thank you very much for
initing and leading this effort.

-Ian.

On Wed, Dec 19, 2018 at 8:23 PM Xin Wang <xi...@gmail.com> wrote:

> Hi all
>         It's been a long time since I started this project. I am very
> pleased to announce that the test coverage of Dubbo is now 64%.
> We have achieved the goal of stage 1: unit test coverage > 60%.
>
> A lot of people submitted prs, the contributors and the number of their prs
> are as follows:
>
>    YunKun Huang (@htynkn)                 5
>    Ian Luo (@beiwei30)                         3
>    Kimm King (@kimming)                       2
>    Xin Wang (@lovepoem)                 1
>    Zonghai Shang (@zonghaishang) 1
>    Song Kun   (@satansk)                        1
>    xialongfei (@stoneapple)                     1
>    钟剑 (@DeadLion)                                1
>    Yang Tao        (@whanice)                   1
>    Qin Yulin (@qinnnyul)                          1
>    Yong Zhu (diecui1202)                         1
>
>    Thank you very much for your contribution.
> Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
> then the project will be completed. If anybody want to take part in, please
> leave a message on these issues?
> Thank you !
>
> [1] https://github.com/apache/incubator-dubbo/issues/1690
> [2] https://github.com/apache/incubator-dubbo/issues/1692
>
> Xin Wang <lo...@hotmail.com> 于2018年4月27日周五 上午10:24写道:
>
> > Hi,all
> >       In order to enhance the test coverage, now the project is started:
> > https://github.com/apache/incubator-dubbo/projects/1,
> > you can also see the related issues in the other entrance page:
> > https://github.com/apache/incubator-dubbo/issues/1702
> >       The test coverage guide is here:
> > https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
> >
> >       Welcome everyone to join in,you can comment on the issue that
> you're
> > interest with.
> >
> > Xin Wang
> > lovepoem@hotmail.com
> >
> >
> >
> >
>