[GitHub] [cassandra] belliottsmith commented on a change in pull request #659: A raft of minor optimizations for replica filtering protection

[GitBox <gi...@apache.org>]

belliottsmith commented on a change in pull request #659:
URL: https://github.com/apache/cassandra/pull/659#discussion_r448037610



##########
File path: src/java/org/apache/cassandra/service/DataResolver.java
##########
@@ -48,8 +48,10 @@
     private static final boolean DROP_OVERSIZED_READ_REPAIR_MUTATIONS =
         Boolean.getBoolean("cassandra.drop_oversized_readrepair_mutations");
 
+    private static final UnaryOperator<PartitionIterator> IDENTITY = UnaryOperator.identity();

Review comment:
       Are you sure this is being allocated when you invoke it? The lambda defined at source should only be instantiated once, so this looks to be an unnecessary obfuscation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org