[jira] Closed: (OFBIZ-1663) POS: All payment types allow change to be made

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1663.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0

You were right Chris it was related to OFBIZ-1706.  So I close this issue even if I discovered that order are not put in the right status  (completed) but stay in created status because of this error :

2008-04-12 20:26:03,562 (Thread-26) [  ServiceDispatcher.java:419:ERROR] Service Error [changeOrderStatus]: %Erreur : Ne peut pas changer le statut de la commande ; le statut ne peut pas Ûtre changÚ.%
2008-04-12 20:26:03,578 (Thread-26) [    TransactionUtil.java:255:ERROR]
---- exception report ----------------------------------------------------------
[TransactionUtil.rollback]
Exception: java.lang.Exception
Message: Stack Trace
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Stack Trace
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:254)
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:236)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:423)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
org.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(OrderChangeHelper.java:158)
org.ofbiz.order.order.OrderChangeHelper.completeOrder(OrderChangeHelper.java:121)
org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:1063)
org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:834)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:624)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:308)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
java.lang.reflect.Method.invoke(Unknown Source)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:120)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Unknown Source)
--------------------------------------------------------------------------------

2008-04-12 20:26:03,578 (Thread-26) [    TransactionUtil.java:265:INFO ] [TransactionUtil.rollback] transaction rolled back
2008-04-12 20:26:03,578 (Thread-26) [  ServiceDispatcher.java:467:DEBUG] Sync service [POSDispatcher/changeOrderStatus] finished in [94] milliseconds
2008-04-12 20:26:03,578 (Thread-26) [  OrderChangeHelper.java:160:ERROR] Problems adjusting order header status for order #RS10010

But as it does not prevent to create the invoice and I have not time to investigate further I close this issue. Maybe it's only because face-to-face is not considered and it assumes that the check is not yet received... If someone is annoyed by this simply open a new issue...

>  POS:  All payment types allow change to be made
> ------------------------------------------------
>
>                 Key: OFBIZ-1663
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1663
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: Release Branch 4.0
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given.  This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.