svn commit: r151764 - spamassassin/trunk/lib/Mail/SpamAssassin.pm

[fe...@apache.org]

Author: felicity
Date: Mon Feb  7 14:03:41 2005
New Revision: 151764

URL: http://svn.apache.org/viewcvs?view=rev&rev=151764
Log:
remove misleading comment -- sorting is set by the locale, possible ascii, but probably not numeric.

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin.pm?view=diff&r1=151763&r2=151764
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin.pm Mon Feb  7 14:03:41 2005
@@ -1595,7 +1595,7 @@
   my @cfs = grep { /\.cf$/i && -f "$dir/$_" } readdir(SA_CF_DIR);
   closedir SA_CF_DIR;
 
-  return map { "$dir/$_" } sort { $a cmp $b } @cfs;	# sort numerically
+  return map { "$dir/$_" } sort { $a cmp $b } @cfs;
 }
 
 ###########################################################################

Re: svn commit: r151764 - spamassassin/trunk/lib/Mail/SpamAssassin.pm

[Theo Van Dinter <fe...@kluge.net>]

On Mon, Feb 07, 2005 at 02:30:46PM -0800, Justin Mason wrote:
> hmm. config files are named "01_foo.cf", "02_blah.cf", so it should
> indeed be numeric sorting because of that.

in /usr/share/spamassassin, yes via our naming convention.
in /etc/mail/spamassassin, it's basically ASCII value.  Unless your
locale is set so that case is ignored, etc.  :)

(any which way though, it's still not really numerically.  100_foo.cf will
come before 20_bar.cf even in /usr/share/spamassassin...)

-- 
Randomly Generated Tagline:
Now, son, you don't want to drink beer.  That's for daddys, and kids with
 fake IDs.
 
 		-- Homer Simpson
 		   The Springfield Files