[GitHub] [airflow] hblanks opened a new pull request #5721: utils: fix process races when killing processes

[GitBox <gi...@apache.org>]

hblanks opened a new pull request #5721: utils: fix process races when killing processes
URL: https://github.com/apache/airflow/pull/5721
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5109
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   airflow.utils.helpers.reap_process_group() can throw uncaught OSErrors
   if processes exit at the wrong time in its execution. Fix this by
   catching all OSErrors that can arise due to a process race, and
   returning from them when the error is ESRCH (process not found).
   
   Traceback from a production system can be found in the JIRA above.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   this functionality is already tested in `tests.utils.test_helpers`; reproducibly testing for additional cases in a process race can only be done with substantially more complicated tests.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   No new functionality, so no new docs.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services