You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/06 14:59:45 UTC

[GitHub] [superset] zhaoyongjie opened a new pull request #13969: fix: annotation modal dateRangePicker saved invalid value

zhaoyongjie opened a new pull request #13969:
URL: https://github.com/apache/superset/pull/13969


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Since moment.js cannot parse `YYY-MM-DD hh:mm a` format, an error will occur.  
   
   Now we use a  consistent format for saving and parsing datetime object.
   
   closes: https://github.com/apache/superset/issues/13958
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### before
   ![image](https://user-images.githubusercontent.com/2244895/113648059-d759ec00-9640-11eb-8b9b-34271b32c3f0.png)
   
   #### After
   ![image](https://user-images.githubusercontent.com/2016594/113729897-0009e080-972a-11eb-871a-ef3fa3c6e019.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13969:
URL: https://github.com/apache/superset/pull/13969#issuecomment-814211266


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=h1) Report
   > Merging [#13969](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=desc) (bf2589c) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.20%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head bf2589c differs from pull request most recent head 1a15e2d. Consider uploading reports for the commit 1a15e2d to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13969/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13969      +/-   ##
   ==========================================
   + Coverage   77.87%   78.08%   +0.20%     
   ==========================================
     Files         935      935              
     Lines       47375    47374       -1     
     Branches     5964     5964              
   ==========================================
   + Hits        36895    36991      +96     
   + Misses      10323    10233      -90     
   + Partials      157      150       -7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.50% <ø> (+6.73%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `63.23% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-59.26%)` | :arrow_down: |
   | [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
   | [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `72.41% <0.00%> (-13.80%)` | :arrow_down: |
   | [...set-frontend/src/components/RefreshLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsL2luZGV4LnRzeA==) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `71.77% <0.00%> (-8.59%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | ... and [39 more](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=footer). Last update [8b9c142...1a15e2d](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13969:
URL: https://github.com/apache/superset/pull/13969#issuecomment-814211266


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=h1) Report
   > Merging [#13969](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=desc) (776f17d) into [master](https://codecov.io/gh/apache/superset/commit/e3efaba7750703250d5053a58df53d2c8c5be78b?el=desc) (e3efaba) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 776f17d differs from pull request most recent head 805aef1. Consider uploading reports for the commit 805aef1 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13969/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13969      +/-   ##
   ==========================================
   - Coverage   78.96%   78.96%   -0.01%     
   ==========================================
     Files         936      936              
     Lines       47409    47408       -1     
     Branches     5941     5940       -1     
   ==========================================
   - Hits        37438    37437       -1     
     Misses       9844     9844              
     Partials      127      127              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `68.45% <100.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `62.96% <100.00%> (-0.28%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=footer). Last update [e3efaba...805aef1](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie closed pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #13969:
URL: https://github.com/apache/superset/pull/13969


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13969:
URL: https://github.com/apache/superset/pull/13969#issuecomment-814211266


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=h1) Report
   > Merging [#13969](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=desc) (bf2589c) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `0.30%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head bf2589c differs from pull request most recent head 805aef1. Consider uploading reports for the commit 805aef1 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13969/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13969      +/-   ##
   ==========================================
   - Coverage   78.87%   78.56%   -0.31%     
   ==========================================
     Files         936      935       -1     
     Lines       47408    47375      -33     
     Branches     5941     5964      +23     
   ==========================================
   - Hits        37393    37222     -171     
   - Misses       9883    10010     +127     
   - Partials      132      143      +11     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.01% <ø> (-3.09%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `63.23% <100.00%> (ø)` | |
   | [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
   | [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
   | [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
   | [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `2.05% <0.00%> (-85.62%)` | :arrow_down: |
   | [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
   | [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | `2.38% <0.00%> (-78.58%)` | :arrow_down: |
   | [...nd/src/dashboard/util/buildFilterScopeTreeEntry.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2J1aWxkRmlsdGVyU2NvcGVUcmVlRW50cnkuanM=) | `0.00% <0.00%> (-73.69%)` | :arrow_down: |
   | ... and [59 more](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=footer). Last update [e3efaba...805aef1](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie merged pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #13969:
URL: https://github.com/apache/superset/pull/13969


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nytai commented on a change in pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #13969:
URL: https://github.com/apache/superset/pull/13969#discussion_r608010019



##########
File path: superset-frontend/src/views/CRUD/annotation/AnnotationModal.tsx
##########
@@ -311,14 +311,13 @@ const AnnotationModal: FunctionComponent<AnnotationModalProps> = ({
           <span className="required">*</span>
         </div>
         <RangePicker
-          format="YYYY-MM-DD hh:mm a"
+          format="YYYY-MM-DD HH:mm"

Review comment:
       We should start collecting these formats in a module.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13969:
URL: https://github.com/apache/superset/pull/13969#issuecomment-814211266


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=h1) Report
   > Merging [#13969](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=desc) (bf2589c) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.69%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head bf2589c differs from pull request most recent head 1a15e2d. Consider uploading reports for the commit 1a15e2d to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13969/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13969      +/-   ##
   ==========================================
   + Coverage   77.87%   78.56%   +0.69%     
   ==========================================
     Files         935      935              
     Lines       47375    47375              
     Branches     5964     5964              
   ==========================================
   + Hits        36895    37222     +327     
   + Misses      10323    10010     -313     
   + Partials      157      143      -14     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.01% <ø> (+5.24%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `63.23% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
   | [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.34% <0.00%> (+0.88%)` | :arrow_up: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.77% <0.00%> (+1.16%)` | :arrow_up: |
   | [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <0.00%> (+1.85%)` | :arrow_up: |
   | ... and [42 more](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=footer). Last update [8b9c142...1a15e2d](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13969: fix: annotation modal dateRangePicker saved invalid value

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13969:
URL: https://github.com/apache/superset/pull/13969#issuecomment-814211266


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=h1) Report
   > Merging [#13969](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=desc) (bf2589c) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.69%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head bf2589c differs from pull request most recent head 1a15e2d. Consider uploading reports for the commit 1a15e2d to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13969/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13969      +/-   ##
   ==========================================
   + Coverage   77.87%   78.56%   +0.69%     
   ==========================================
     Files         935      935              
     Lines       47375    47375              
     Branches     5964     5964              
   ==========================================
   + Hits        36895    37222     +327     
   + Misses      10323    10010     -313     
   + Partials      157      143      -14     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.01% <ø> (+5.24%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `63.23% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
   | [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.34% <0.00%> (+0.88%)` | :arrow_up: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.77% <0.00%> (+1.16%)` | :arrow_up: |
   | [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <0.00%> (+1.85%)` | :arrow_up: |
   | ... and [42 more](https://codecov.io/gh/apache/superset/pull/13969/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=footer). Last update [8b9c142...1a15e2d](https://codecov.io/gh/apache/superset/pull/13969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org