[GitHub] [incubator-druid] himanshug opened a new pull request #8243: make double sum/min/max agg work on string columns

[GitBox <gi...@apache.org>]

himanshug opened a new pull request #8243: make double sum/min/max agg work on string columns
URL: https://github.com/apache/incubator-druid/pull/8243
 
 
   Partial work towards #8148 . There would be follow up PR to do same for other core aggregators once this is merged.
   
   ### Description
   This patch adds handling of single/multi value column handling by double sum/min/max aggregators to do a best effort parsing string as double.
   
   `StringColumnDoubleAggregatorWrapper` and `StringColumnDoubleBufferAggregatorWrapper` classes are introduced that can wrap existing double aggregators to handle string columns. Both of the classes are used by `SimpleDoubleAggregatorFactory` to be used when input column is known to be of String type.
   
   Currently it does not work if `extractionFn` instead of `fieldName` is provided. (Related #8242 )
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org