You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/14 23:05:42 UTC
[GitHub] jmeter pull request #329: Expansion of "Add expand/collapse all menu in rend...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/329
Expansion of "Add expand/collapse all menu in render XML view" (PR #294)
## Description
Update and expansion to PR #294. I hope @max3163 doesn't mind. It improves upon the UX of the original (good) idea by having the right click also select the node, rather than right click bring up the menu but not changing the selected node which felt counter intuitive.
## Motivation and Context
Makes exploring the XML results far easier, especially for large documents.
## How Has This Been Tested?
Manually downloading a few different xml docs and right clicking, expanding and collapsing in various places.
## Screenshots (if appropriate):
Right clicking on the element, selects it and brings up the menu:
Expands all:
## Types of changes
- New feature (non-breaking change which adds functionality)
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter pr_294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit f3819f9e94e6e9890f0483f645f214137867e547
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-14T22:29:38Z
formatting
commit afb038ae7341f6448c1573c073d5f140371c1e82
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-14T22:31:10Z
Right click XML view will select node and show menu for collapse/expand.
commit 094716219c6a22bebf16048946b291d9dbab467e
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-14T23:03:55Z
Updated docs
----
---
[GitHub] jmeter issue #329: Expansion of "Add expand/collapse all menu in render XML ...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/329
Hi @ham1 ,
Thanks for PR.
As commented on @max3163 PR, I feel this renderer is not very useful.
I think improving more the XPath Tester and removing this one would bring a better UX ?
Because usually, you 'll use the XXX Tester to test extractions (XPath, JSON, CSS/JQuery, Regexp). For XML it would be XPath, in this case a formatted and foldable/unfoldable document would be more helpful no ?
Regards
---
[GitHub] jmeter issue #329: Expansion of "Add expand/collapse all menu in render XML ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/329
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=h1) Report
> Merging [#329](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/2628269bce667670456bf57bbd6f6a6310683aa8?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `3.22%`.
[](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #329 +/- ##
============================================
- Coverage 57.82% 57.79% -0.04%
+ Complexity 9937 9936 -1
============================================
Files 1141 1141
Lines 73227 73274 +47
Branches 7305 7310 +5
============================================
- Hits 42347 42346 -1
- Misses 28413 28461 +48
Partials 2467 2467
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nts/org/apache/jmeter/visualizers/RenderAsXML.java](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvUmVuZGVyQXNYTUwuamF2YQ==) | `4.8% <3.22%> (-2.9%)` | `3 <1> (ø)` | |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.38% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=footer). Last update [2628269...f8c7a06](https://codecov.io/gh/apache/jmeter/pull/329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #329: Expansion of "Add expand/collapse all menu in render XML ...
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/329
I think this is useful for people who are exploring the xml responses.
I agree that this could be removed if the XPath tester was improved with the same view.
---
[GitHub] jmeter pull request #329: Expansion of "Add expand/collapse all menu in rend...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/329
---