You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/07/15 12:48:10 UTC
[PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
MartijnVisser opened a new pull request, #28749:
URL: https://github.com/apache/flink/pull/28749
## What is the purpose of the change
FLINK-40150. The six terminated-reason tests in `RescaleTimelineITCase` only assert
when rescale history is enabled, yet ran as `@TestTemplate`: on the disabled-history
parameter each paid for a `MiniCluster` startup before `assumeThat` aborted, and three
rebuilt the cluster on top of that. This eliminates those wasted startups.
The jira was scoped to the 3 assume+rebuild methods; this broadens it to all 6
assume-guarded methods, since the `assume`+enabled-only pattern applies to the same set.
## Brief change log
- Extract shared fixture and helpers into a new abstract `RescaleTimelineITCaseBase`.
- Move the 6 enabled-only tests to a new non-parameterized `RescaleTimelineHistoryEnabledITCase`;
each starts one cluster per test with the configuration it needs (no throwaway rebuild),
and the `assumeThat` guards are dropped.
- `RescaleTimelineITCase` keeps the 8 genuinely per-parameter cases (and the 2 `@Disabled`).
No production code and no behavior change; all timeouts and configs are preserved.
## Verifying this change
This change is a test-only refactor covered by existing tests:
`RescaleTimelineITCase` (16 executed over 2 parameters, 2 disabled) and
`RescaleTimelineHistoryEnabledITCase` (6, each run once) both pass.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (Claude Code, Claude Opus 4.8)
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #28749:
URL: https://github.com/apache/flink/pull/28749#issuecomment-5686011522
Looks like it was good that I rebased since CI smells like it's locked 🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #28749:
URL: https://github.com/apache/flink/pull/28749#issuecomment-5679800313
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28749:
URL: https://github.com/apache/flink/pull/28749#issuecomment-4980802987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a09f08d76ddf5d7b34e4eb13bf23631333663029",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a09f08d76ddf5d7b34e4eb13bf23631333663029",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a09f08d76ddf5d7b34e4eb13bf23631333663029 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28749:
URL: https://github.com/apache/flink/pull/28749#issuecomment-4983681418
The test failure is unrelated. But you may rerun for green CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #28749:
URL: https://github.com/apache/flink/pull/28749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org