You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/12/14 19:51:14 UTC
Review Request 41358: Enforce granular role-based access control for
alert functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
Bugs: AMBARI-14141
https://issues.apache.org/jira/browse/AMBARI-14141
Repository: ambari
Description
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
--------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (cluster) | | | | | (+) | (+)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d47d8d3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 02eb5b4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java ee2b9b1
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 788c2a7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ae560d9
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 155a6a7
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4c20767
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql dc08960
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 10b1ac6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
Diff: https://reviews.apache.org/r/41358/diff/
Testing
-------
Manually tested
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:59.413s
[INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
[INFO] Final Memory: 70M/1085M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 15, 2015, 4:48 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java, lines 131-134
> > <https://reviews.apache.org/r/41358/diff/1/?file=1163116#file1163116line131>
> >
> > Alert targets are actually not bound to a cluster; they are defined on the api/v1/alert_target endpoint. As a result, should this be a different permission?
On line 253, the resource type is declared as AMBARI, so this technically checks for users with permissions to manage alerts at the Ambari level. Only administrative users can do this. So I think that sould be correct.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110565
-----------------------------------------------------------
On Dec. 14, 2015, 1:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:51 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d47d8d3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 02eb5b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java ee2b9b1
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 788c2a7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ae560d9
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 155a6a7
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4c20767
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql dc08960
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 10b1ac6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110565
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java (line 174)
<https://reviews.apache.org/r/41358/#comment170512>
Consider that you can have 100,000 historical alerts in the system. Do you really want to iterate over all of them every time? That's a lot of entity checking. Meanwhile, alert history is read-only, so you should only have to check this once outside of the loop, no?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java (line 164)
<https://reviews.apache.org/r/41358/#comment170511>
Consider that you can have 10,000 current alerts in the system. Do you really want to iterate over all of them every time? That's a lot of entity checking. Meanwhile, alert notices are read-only, so you should only have to check this once outside of the loop, no?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java (lines 131 - 134)
<https://reviews.apache.org/r/41358/#comment170509>
Alert targets are actually not bound to a cluster; they are defined on the api/v1/alert_target endpoint. As a result, should this be a different permission?
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java (line 75)
<https://reviews.apache.org/r/41358/#comment170510>
Alert targets are their own endpoint, not scoped under a cluster.
- Jonathan Hurley
On Dec. 14, 2015, 1:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:51 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d47d8d3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 02eb5b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java ee2b9b1
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 788c2a7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ae560d9
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 155a6a7
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4c20767
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql dc08960
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 10b1ac6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, lines 523-524
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166688#file1166688line523>
> >
> > If you're in this method, pretty much "managed" is always true. The only time it's not is if you're toggling the definition off. So, why not make this simpler and not have every if-statement set managed. Just unset it in the enable if-statement.
>
> Robert Levas wrote:
> Then it wont be clear if the only thing that is being changed is the enabled/disabled flag. For how do I know the difference between the alert is being enabled and scheduled or just enabled?
>
> Jonathan Hurley wrote:
> Check the request map to see what's a part of the request? Unless the web client always sends down the entire JSON structure even when only changing 1 field.
When disabling an alert, the web client sends the following properties in the map:
- AlertDefinition/name
- AlertDefinition/id
- AlertDefinition/label
- AlertDefinition/cluster_name
- AlertDefinition/enabled
Becuase of this, the checks that are being performed are necessary.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110957
-----------------------------------------------------------
On Dec. 16, 2015, 1:58 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, lines 523-524
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166688#file1166688line523>
> >
> > If you're in this method, pretty much "managed" is always true. The only time it's not is if you're toggling the definition off. So, why not make this simpler and not have every if-statement set managed. Just unset it in the enable if-statement.
>
> Robert Levas wrote:
> Then it wont be clear if the only thing that is being changed is the enabled/disabled flag. For how do I know the difference between the alert is being enabled and scheduled or just enabled?
Check the request map to see what's a part of the request? Unless the web client always sends down the entire JSON structure even when only changing 1 field.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110957
-----------------------------------------------------------
On Dec. 16, 2015, 1:58 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, lines 523-524
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166688#file1166688line523>
> >
> > If you're in this method, pretty much "managed" is always true. The only time it's not is if you're toggling the definition off. So, why not make this simpler and not have every if-statement set managed. Just unset it in the enable if-statement.
Then it wont be clear if the only thing that is being changed is the enabled/disabled flag. For how do I know the difference between the alert is being enabled and scheduled or just enabled?
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java, line 581
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166688#file1166688line581>
> >
> > JSON could be slightly different and still be the same - Why do a comparison here?
Good point, I will remove the equality check here.
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java, line 233
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166689#file1166689line233>
> >
> > Wrong log statement; you're deleting the group here, not a target.
This was already there, but I will fix it to read "Deleting alert group {}"
> On Dec. 17, 2015, 9:20 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java, line 162
> > <https://reviews.apache.org/r/41358/diff/2/?file=1166692#file1166692line162>
> >
> > I still see some of these checks on a per-entity basis. Here and above in the definition resource provider. Considering that there could be 1000's of alerts here, can't we do this outside of the loop?
fixing...
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110957
-----------------------------------------------------------
On Dec. 16, 2015, 1:58 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110957
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java (lines 523 - 524)
<https://reviews.apache.org/r/41358/#comment170972>
If you're in this method, pretty much "managed" is always true. The only time it's not is if you're toggling the definition off. So, why not make this simpler and not have every if-statement set managed. Just unset it in the enable if-statement.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java (line 581)
<https://reviews.apache.org/r/41358/#comment170971>
JSON could be slightly different and still be the same - Why do a comparison here?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java (line 233)
<https://reviews.apache.org/r/41358/#comment170973>
Wrong log statement; you're deleting the group here, not a target.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java (line 162)
<https://reviews.apache.org/r/41358/#comment170974>
I still see some of these checks on a per-entity basis. Here and above in the definition resource provider. Considering that there could be 1000's of alerts here, can't we do this outside of the loop?
- Jonathan Hurley
On Dec. 16, 2015, 1:58 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110973
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 17, 2015, 11:27 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 11:27 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 11:27 a.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
Bugs: AMBARI-14141
https://issues.apache.org/jira/browse/AMBARI-14141
Repository: ambari
Description
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
--------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (cluster) | | | | | (+) | (+)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
Diff: https://reviews.apache.org/r/41358/diff/
Testing
-------
Manually tested
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:59.413s
[INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
[INFO] Final Memory: 70M/1085M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 10:59 a.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
Bugs: AMBARI-14141
https://issues.apache.org/jira/browse/AMBARI-14141
Repository: ambari
Description
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
--------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (cluster) | | | | | (+) | (+)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
Diff: https://reviews.apache.org/r/41358/diff/
Testing
-------
Manually tested
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:59.413s
[INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
[INFO] Final Memory: 70M/1085M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 1:58 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
Bugs: AMBARI-14141
https://issues.apache.org/jira/browse/AMBARI-14141
Repository: ambari
Description
-------
Enforce granular role-based access control for alert functions:
| Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
--------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
Enable/disable alerts (cluster) | | | | | (+) | (+)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java a29f151
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java dde934d
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 795db77
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 57eafa6
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a980ec
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 60bbd30
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f1fb358
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 1d9cc71
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55846c0
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f289bc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
Diff: https://reviews.apache.org/r/41358/diff/
Testing
-------
Manually tested
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:59.413s
[INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
[INFO] Final Memory: 70M/1085M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 41358: Enforce granular role-based access control
for alert functions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41358/#review110485
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 14, 2015, 1:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41358/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 1:51 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-14141
> https://issues.apache.org/jira/browse/AMBARI-14141
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enforce granular role-based access control for alert functions:
>
> | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator
> --------------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
> View alerts (service) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (service) | | | (+) | (+) | (+) | (+)
> View alerts (cluster) | (+) | (+) | (+) | (+) | (+) | (+)
> Enable/disable alerts (cluster) | | | | | (+) | (+)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java d47d8d3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bc5f956
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java 215bc8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 89ee69a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java 8f0e526
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4dc4dcf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProviderUtils.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java a310259
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java d817ad7
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java 02eb5b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java ee2b9b1
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 788c2a7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ae560d9
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 155a6a7
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4c20767
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql dc08960
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 10b1ac6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java e589537
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java a41eecf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 99aca45
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 3322da6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 4f0263b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java 6cde0c2
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 1c440eb
>
> Diff: https://reviews.apache.org/r/41358/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:00:59.413s
> [INFO] Finished at: Mon Dec 14 13:37:40 EST 2015
> [INFO] Final Memory: 70M/1085M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>