You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2015/12/01 02:23:53 UTC

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

bump. Vote thread is going and needs two votes. David can you test it with
master cli and confirm it is all working?

On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <st...@gmail.com> wrote:

> Starting the vote for this
>
> On Tue, Nov 17, 2015 at 9:31 AM, David Barth <da...@canonical.com>
> wrote:
>
>> Hey,
>>
>> I would like to update the 4.x series of cordova-ubuntu with a couple of
>> fixes, and make it the last in the series supporting the cordova-cli 4.3.1
>> branch as well
>>
>>    - Cb 9868 - Should propose to install missing Ubuntu dependencies on
>>    platform add <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
>>    - Cb 9694 - Add support for HTTP urls
>>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
>>    - Cb 9806 - Add icon to project defaults
>>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
>>
>> So here is the traditional:
>>
>> Does anyone have any reason to delay a cordova-ubuntu platform release?
>> Any outstanding patches to land?
>>
>> If not, I will start the release tomorrow.
>>
>> David
>>
>
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Steven Gill <st...@gmail.com>.
When you do a cordova platform add https://github.com/apache/cordova-ubuntu,
our tools won't run npm install (it will soon though) when it fetches so
those node_modules will be missing. This issue won't exist when installing
from npm.

To solve this, we check node_modules into github.

On Thu, Dec 3, 2015 at 12:10 PM, David Barth <da...@canonical.com>
wrote:

> Shouldn't that be just pinned versions in package.json ?
>
> Can you share the install issues you had. I can compare and adjust quickly
> with a couple LXD containers.
>
> On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > We should check into git repo node_modules
> > while recreating the archive I saw differences, I think this was due to
> the
> > npm version I used.
> > But adding from git is broken, since git doesn't node_modules (i.e.
> > shelljs, and others)
> > But this should not stop the release since the dist archive contains the
> > node_modules and from npm will have node_modules
> >
> >
> > On Wed, Dec 2, 2015 at 1:55 PM Steven Gill <st...@gmail.com>
> wrote:
> >
> > > Okay sweet. Can you add a +1 on the vote thread that is open for
> Ubuntu.
> > We
> > > need one other committer to give a +1 so I can wrapnit up and publish
> > > On Dec 2, 2015 10:47 AM, "David Barth" <da...@canonical.com>
> > wrote:
> > >
> > > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <stevengill97@gmail.com
> >
> > > > wrote:
> > > >
> > > > > Which raw api changes to cordova@5.3.x make it unusable with
> ubuntu?
> > > As
> > > > > far
> > > > > as I know, cordova-ubuntu should work the same with cordova@4.x
> and
> > > > > cordova@5.x. The platform API changes aren't necessary to work
> with
> > > > > cordova@5.x
> > > > >
> > > >
> > > > It worked for most commands, except with options like build --device.
> > > This
> > > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > > >
> > > >
> > > > >
> > > > > We probably won't do a update to cordova@4.x unless a security
> > concern
> > > > > comes up.
> > > > >
> > > >
> > > > Ok, makes sense. Anyway, I have a distro-patched version available in
> > an
> > > > Ubuntu PPA (personal archive) at :
> > > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for
> people
> > > who
> > > > want a quick start for Ubuntu only.
> > > >
> > > > I imagine it will be resolved by next month, and then I can propose a
> > > > debian package with cordova-cli 5 or 6 as well.
> > > >
> > > >
> > > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> > next
> > > > week
> > > > > sometime. If we can get the fixes in by then, great!
> > > > >
> > > >
> > > > Ok
> > > >
> > > >
> > > > >
> > > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> > (master).
> > > If
> > > > > thinks look good, we should get you and one other person to vote on
> > the
> > > > > vote thread for cordova-ubuntu so I can officially release it on
> npm.
> > > > >
> > > >
> > > > I have finally been able to test with both cordova-cli @4.3.1 and
> > master,
> > > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2
> LTS,
> > > to:
> > > >
> > > > platform add ubuntu
> > > > build --device
> > > > run --device
> > > >
> > > > It is still not super pretty but there are no regressions and bugs
> are
> > > > fixed.
> > > >
> > > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > > >
> > > > David
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by David Barth <da...@canonical.com>.
Shouldn't that be just pinned versions in package.json ?

Can you share the install issues you had. I can compare and adjust quickly
with a couple LXD containers.

On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana <cs...@gmail.com> wrote:

> We should check into git repo node_modules
> while recreating the archive I saw differences, I think this was due to the
> npm version I used.
> But adding from git is broken, since git doesn't node_modules (i.e.
> shelljs, and others)
> But this should not stop the release since the dist archive contains the
> node_modules and from npm will have node_modules
>
>
> On Wed, Dec 2, 2015 at 1:55 PM Steven Gill <st...@gmail.com> wrote:
>
> > Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu.
> We
> > need one other committer to give a +1 so I can wrapnit up and publish
> > On Dec 2, 2015 10:47 AM, "David Barth" <da...@canonical.com>
> wrote:
> >
> > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <st...@gmail.com>
> > > wrote:
> > >
> > > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> > As
> > > > far
> > > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > > cordova@5.x. The platform API changes aren't necessary to work with
> > > > cordova@5.x
> > > >
> > >
> > > It worked for most commands, except with options like build --device.
> > This
> > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > >
> > >
> > > >
> > > > We probably won't do a update to cordova@4.x unless a security
> concern
> > > > comes up.
> > > >
> > >
> > > Ok, makes sense. Anyway, I have a distro-patched version available in
> an
> > > Ubuntu PPA (personal archive) at :
> > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people
> > who
> > > want a quick start for Ubuntu only.
> > >
> > > I imagine it will be resolved by next month, and then I can propose a
> > > debian package with cordova-cli 5 or 6 as well.
> > >
> > >
> > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> next
> > > week
> > > > sometime. If we can get the fixes in by then, great!
> > > >
> > >
> > > Ok
> > >
> > >
> > > >
> > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> (master).
> > If
> > > > thinks look good, we should get you and one other person to vote on
> the
> > > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > > >
> > >
> > > I have finally been able to test with both cordova-cli @4.3.1 and
> master,
> > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS,
> > to:
> > >
> > > platform add ubuntu
> > > build --device
> > > run --device
> > >
> > > It is still not super pretty but there are no regressions and bugs are
> > > fixed.
> > >
> > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > >
> > > David
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Carlos Santana <cs...@gmail.com>.
We should check into git repo node_modules
while recreating the archive I saw differences, I think this was due to the
npm version I used.
But adding from git is broken, since git doesn't node_modules (i.e.
shelljs, and others)
But this should not stop the release since the dist archive contains the
node_modules and from npm will have node_modules


On Wed, Dec 2, 2015 at 1:55 PM Steven Gill <st...@gmail.com> wrote:

> Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We
> need one other committer to give a +1 so I can wrapnit up and publish
> On Dec 2, 2015 10:47 AM, "David Barth" <da...@canonical.com> wrote:
>
> > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <st...@gmail.com>
> > wrote:
> >
> > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> As
> > > far
> > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > cordova@5.x. The platform API changes aren't necessary to work with
> > > cordova@5.x
> > >
> >
> > It worked for most commands, except with options like build --device.
> This
> > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> >
> >
> > >
> > > We probably won't do a update to cordova@4.x unless a security concern
> > > comes up.
> > >
> >
> > Ok, makes sense. Anyway, I have a distro-patched version available in an
> > Ubuntu PPA (personal archive) at :
> > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people
> who
> > want a quick start for Ubuntu only.
> >
> > I imagine it will be resolved by next month, and then I can propose a
> > debian package with cordova-cli 5 or 6 as well.
> >
> >
> > > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> > week
> > > sometime. If we can get the fixes in by then, great!
> > >
> >
> > Ok
> >
> >
> > >
> > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master).
> If
> > > thinks look good, we should get you and one other person to vote on the
> > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > >
> >
> > I have finally been able to test with both cordova-cli @4.3.1 and master,
> > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS,
> to:
> >
> > platform add ubuntu
> > build --device
> > run --device
> >
> > It is still not super pretty but there are no regressions and bugs are
> > fixed.
> >
> > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> >
> > David
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Steven Gill <st...@gmail.com>.
Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We
need one other committer to give a +1 so I can wrapnit up and publish
On Dec 2, 2015 10:47 AM, "David Barth" <da...@canonical.com> wrote:

> On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> > far
> > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > cordova@5.x. The platform API changes aren't necessary to work with
> > cordova@5.x
> >
>
> It worked for most commands, except with options like build --device. This
> is now fixed in 5.4 thanks to the recent cordova-lib commit.
>
>
> >
> > We probably won't do a update to cordova@4.x unless a security concern
> > comes up.
> >
>
> Ok, makes sense. Anyway, I have a distro-patched version available in an
> Ubuntu PPA (personal archive) at :
> https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people who
> want a quick start for Ubuntu only.
>
> I imagine it will be resolved by next month, and then I can propose a
> debian package with cordova-cli 5 or 6 as well.
>
>
> > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> week
> > sometime. If we can get the fixes in by then, great!
> >
>
> Ok
>
>
> >
> > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> > thinks look good, we should get you and one other person to vote on the
> > vote thread for cordova-ubuntu so I can officially release it on npm.
> >
>
> I have finally been able to test with both cordova-cli @4.3.1 and master,
> ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS, to:
>
> platform add ubuntu
> build --device
> run --device
>
> It is still not super pretty but there are no regressions and bugs are
> fixed.
>
> So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
>
> David
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by David Barth <da...@canonical.com>.
On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <st...@gmail.com> wrote:

> Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> far
> as I know, cordova-ubuntu should work the same with cordova@4.x and
> cordova@5.x. The platform API changes aren't necessary to work with
> cordova@5.x
>

It worked for most commands, except with options like build --device. This
is now fixed in 5.4 thanks to the recent cordova-lib commit.


>
> We probably won't do a update to cordova@4.x unless a security concern
> comes up.
>

Ok, makes sense. Anyway, I have a distro-patched version available in an
Ubuntu PPA (personal archive) at :
https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people who
want a quick start for Ubuntu only.

I imagine it will be resolved by next month, and then I can propose a
debian package with cordova-cli 5 or 6 as well.


> Good idea to improve CB-9590. We are hoping to get cordova@6 out next week
> sometime. If we can get the fixes in by then, great!
>

Ok


>
> Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> thinks look good, we should get you and one other person to vote on the
> vote thread for cordova-ubuntu so I can officially release it on npm.
>

I have finally been able to test with both cordova-cli @4.3.1 and master,
ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS, to:

platform add ubuntu
build --device
run --device

It is still not super pretty but there are no regressions and bugs are
fixed.

So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.

David

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Carlos Santana <cs...@gmail.com>.
visual inspection looks good, and only touches ubuntu specific code.
Go ahead and merge it.


On Wed, Dec 2, 2015 at 6:56 AM David Barth <da...@canonical.com>
wrote:

> On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > David do we need to have the CB-9618 fix in cordova-lib before continuing
> > vote?
> >
>
> Not strictly speaking. You can manage to prep, build and run an app on
> Ubuntu if you add some symlinks or fake icon file to pass the check.
>
>
> > If that so, do you think you have PR ready soon to review and get into
> > master to be able to have a cli that support new ubuntu 4.3.1
> >
>
> In any case, I have re-opened a pull request with the change:
> https://github.com/apache/cordova-lib/pull/347 We can see that in
> parallel.
>
> David
>
>
> > On Tue, Dec 1, 2015 at 4:02 PM Steven Gill <st...@gmail.com>
> wrote:
> >
> > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> As
> > > far
> > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > cordova@5.x. The platform API changes aren't necessary to work with
> > > cordova@5.x
> > >
> > > We probably won't do a update to cordova@4.x unless a security concern
> > > comes up.
> > >
> > > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> > week
> > > sometime. If we can get the fixes in by then, great!
> > >
> > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master).
> If
> > > thinks look good, we should get you and one other person to vote on the
> > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > >
> > > When making changes to cordova-lib, make sure to send them as PRs still
> > so
> > > people can review them. Especially if the change can possible affect
> > other
> > > platforms.
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Dec 1, 2015 at 9:08 AM, David Barth <david.barth@canonical.com
> >
> > > wrote:
> > >
> > > > Re-doing a round of testing right now.
> > > >
> > > > But, to be frank that icon fix in cordova-lib is quite needed,
> > otherwise
> > > > the icon "errors" make it unnecessarily complicated to prepare a
> > project
> > > > for building. ie
> > > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> > > >
> > > > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > > > cordova@4.3.1 and pin the 2 releases together if that's still
> > possible.
> > > > Being fully compatible with the newest cordova@5.3.x is still on my
> > todo
> > > > list, because of the raw api changes.
> > > >
> > > > I'll be improving
> > > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just
> > next
> > > > based on the last PR comment.
> > > >
> > > > David
> > > >
> > > > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <st...@gmail.com>
> > > > wrote:
> > > >
> > > > > bump. Vote thread is going and needs two votes. David can you test
> it
> > > > with
> > > > > master cli and confirm it is all working?
> > > > >
> > > > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <
> stevengill97@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Starting the vote for this
> > > > > >
> > > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > > > david.barth@canonical.com>
> > > > > > wrote:
> > > > > >
> > > > > >> Hey,
> > > > > >>
> > > > > >> I would like to update the 4.x series of cordova-ubuntu with a
> > > couple
> > > > of
> > > > > >> fixes, and make it the last in the series supporting the
> > cordova-cli
> > > > > 4.3.1
> > > > > >> branch as well
> > > > > >>
> > > > > >>    - Cb 9868 - Should propose to install missing Ubuntu
> > dependencies
> > > > on
> > > > > >>    platform add <
> > > > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > > > >>    - Cb 9694 - Add support for HTTP urls
> > > > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> > > > > >>    - Cb 9806 - Add icon to project defaults
> > > > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> > > > > >>
> > > > > >> So here is the traditional:
> > > > > >>
> > > > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > > > release?
> > > > > >> Any outstanding patches to land?
> > > > > >>
> > > > > >> If not, I will start the release tomorrow.
> > > > > >>
> > > > > >> David
> > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by David Barth <da...@canonical.com>.
On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana <cs...@gmail.com> wrote:

> David do we need to have the CB-9618 fix in cordova-lib before continuing
> vote?
>

Not strictly speaking. You can manage to prep, build and run an app on
Ubuntu if you add some symlinks or fake icon file to pass the check.


> If that so, do you think you have PR ready soon to review and get into
> master to be able to have a cli that support new ubuntu 4.3.1
>

In any case, I have re-opened a pull request with the change:
https://github.com/apache/cordova-lib/pull/347 We can see that in parallel.

David


> On Tue, Dec 1, 2015 at 4:02 PM Steven Gill <st...@gmail.com> wrote:
>
> > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> > far
> > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > cordova@5.x. The platform API changes aren't necessary to work with
> > cordova@5.x
> >
> > We probably won't do a update to cordova@4.x unless a security concern
> > comes up.
> >
> > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> week
> > sometime. If we can get the fixes in by then, great!
> >
> > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> > thinks look good, we should get you and one other person to vote on the
> > vote thread for cordova-ubuntu so I can officially release it on npm.
> >
> > When making changes to cordova-lib, make sure to send them as PRs still
> so
> > people can review them. Especially if the change can possible affect
> other
> > platforms.
> >
> >
> >
> >
> >
> > On Tue, Dec 1, 2015 at 9:08 AM, David Barth <da...@canonical.com>
> > wrote:
> >
> > > Re-doing a round of testing right now.
> > >
> > > But, to be frank that icon fix in cordova-lib is quite needed,
> otherwise
> > > the icon "errors" make it unnecessarily complicated to prepare a
> project
> > > for building. ie
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> > >
> > > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > > cordova@4.3.1 and pin the 2 releases together if that's still
> possible.
> > > Being fully compatible with the newest cordova@5.3.x is still on my
> todo
> > > list, because of the raw api changes.
> > >
> > > I'll be improving
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just
> next
> > > based on the last PR comment.
> > >
> > > David
> > >
> > > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <st...@gmail.com>
> > > wrote:
> > >
> > > > bump. Vote thread is going and needs two votes. David can you test it
> > > with
> > > > master cli and confirm it is all working?
> > > >
> > > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <stevengill97@gmail.com
> >
> > > > wrote:
> > > >
> > > > > Starting the vote for this
> > > > >
> > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > > david.barth@canonical.com>
> > > > > wrote:
> > > > >
> > > > >> Hey,
> > > > >>
> > > > >> I would like to update the 4.x series of cordova-ubuntu with a
> > couple
> > > of
> > > > >> fixes, and make it the last in the series supporting the
> cordova-cli
> > > > 4.3.1
> > > > >> branch as well
> > > > >>
> > > > >>    - Cb 9868 - Should propose to install missing Ubuntu
> dependencies
> > > on
> > > > >>    platform add <
> > > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > > >>    - Cb 9694 - Add support for HTTP urls
> > > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> > > > >>    - Cb 9806 - Add icon to project defaults
> > > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> > > > >>
> > > > >> So here is the traditional:
> > > > >>
> > > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > > release?
> > > > >> Any outstanding patches to land?
> > > > >>
> > > > >> If not, I will start the release tomorrow.
> > > > >>
> > > > >> David
> > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Carlos Santana <cs...@gmail.com>.
David do we need to have the CB-9618 fix in cordova-lib before continuing
vote?
If that so, do you think you have PR ready soon to review and get into
master to be able to have a cli that support new ubuntu 4.3.1

On Tue, Dec 1, 2015 at 4:02 PM Steven Gill <st...@gmail.com> wrote:

> Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> far
> as I know, cordova-ubuntu should work the same with cordova@4.x and
> cordova@5.x. The platform API changes aren't necessary to work with
> cordova@5.x
>
> We probably won't do a update to cordova@4.x unless a security concern
> comes up.
>
> Good idea to improve CB-9590. We are hoping to get cordova@6 out next week
> sometime. If we can get the fixes in by then, great!
>
> Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> thinks look good, we should get you and one other person to vote on the
> vote thread for cordova-ubuntu so I can officially release it on npm.
>
> When making changes to cordova-lib, make sure to send them as PRs still so
> people can review them. Especially if the change can possible affect other
> platforms.
>
>
>
>
>
> On Tue, Dec 1, 2015 at 9:08 AM, David Barth <da...@canonical.com>
> wrote:
>
> > Re-doing a round of testing right now.
> >
> > But, to be frank that icon fix in cordova-lib is quite needed, otherwise
> > the icon "errors" make it unnecessarily complicated to prepare a project
> > for building. ie
> > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> >
> > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > cordova@4.3.1 and pin the 2 releases together if that's still possible.
> > Being fully compatible with the newest cordova@5.3.x is still on my todo
> > list, because of the raw api changes.
> >
> > I'll be improving
> > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just next
> > based on the last PR comment.
> >
> > David
> >
> > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <st...@gmail.com>
> > wrote:
> >
> > > bump. Vote thread is going and needs two votes. David can you test it
> > with
> > > master cli and confirm it is all working?
> > >
> > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <st...@gmail.com>
> > > wrote:
> > >
> > > > Starting the vote for this
> > > >
> > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > david.barth@canonical.com>
> > > > wrote:
> > > >
> > > >> Hey,
> > > >>
> > > >> I would like to update the 4.x series of cordova-ubuntu with a
> couple
> > of
> > > >> fixes, and make it the last in the series supporting the cordova-cli
> > > 4.3.1
> > > >> branch as well
> > > >>
> > > >>    - Cb 9868 - Should propose to install missing Ubuntu dependencies
> > on
> > > >>    platform add <
> > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > >>    - Cb 9694 - Add support for HTTP urls
> > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> > > >>    - Cb 9806 - Add icon to project defaults
> > > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> > > >>
> > > >> So here is the traditional:
> > > >>
> > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > release?
> > > >> Any outstanding patches to land?
> > > >>
> > > >> If not, I will start the release tomorrow.
> > > >>
> > > >> David
> > > >>
> > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by Steven Gill <st...@gmail.com>.
Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As far
as I know, cordova-ubuntu should work the same with cordova@4.x and
cordova@5.x. The platform API changes aren't necessary to work with
cordova@5.x

We probably won't do a update to cordova@4.x unless a security concern
comes up.

Good idea to improve CB-9590. We are hoping to get cordova@6 out next week
sometime. If we can get the fixes in by then, great!

Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
thinks look good, we should get you and one other person to vote on the
vote thread for cordova-ubuntu so I can officially release it on npm.

When making changes to cordova-lib, make sure to send them as PRs still so
people can review them. Especially if the change can possible affect other
platforms.





On Tue, Dec 1, 2015 at 9:08 AM, David Barth <da...@canonical.com>
wrote:

> Re-doing a round of testing right now.
>
> But, to be frank that icon fix in cordova-lib is quite needed, otherwise
> the icon "errors" make it unnecessarily complicated to prepare a project
> for building. ie
> https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
>
> At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> cordova@4.3.1 and pin the 2 releases together if that's still possible.
> Being fully compatible with the newest cordova@5.3.x is still on my todo
> list, because of the raw api changes.
>
> I'll be improving
> https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just next
> based on the last PR comment.
>
> David
>
> On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > bump. Vote thread is going and needs two votes. David can you test it
> with
> > master cli and confirm it is all working?
> >
> > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <st...@gmail.com>
> > wrote:
> >
> > > Starting the vote for this
> > >
> > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> david.barth@canonical.com>
> > > wrote:
> > >
> > >> Hey,
> > >>
> > >> I would like to update the 4.x series of cordova-ubuntu with a couple
> of
> > >> fixes, and make it the last in the series supporting the cordova-cli
> > 4.3.1
> > >> branch as well
> > >>
> > >>    - Cb 9868 - Should propose to install missing Ubuntu dependencies
> on
> > >>    platform add <
> > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > >>    - Cb 9694 - Add support for HTTP urls
> > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> > >>    - Cb 9806 - Add icon to project defaults
> > >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> > >>
> > >> So here is the traditional:
> > >>
> > >> Does anyone have any reason to delay a cordova-ubuntu platform
> release?
> > >> Any outstanding patches to land?
> > >>
> > >> If not, I will start the release tomorrow.
> > >>
> > >> David
> > >>
> > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Posted by David Barth <da...@canonical.com>.
Re-doing a round of testing right now.

But, to be frank that icon fix in cordova-lib is quite needed, otherwise
the icon "errors" make it unnecessarily complicated to prepare a project
for building. ie
https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618

At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
cordova@4.3.1 and pin the 2 releases together if that's still possible.
Being fully compatible with the newest cordova@5.3.x is still on my todo
list, because of the raw api changes.

I'll be improving
https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just next
based on the last PR comment.

David

On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <st...@gmail.com> wrote:

> bump. Vote thread is going and needs two votes. David can you test it with
> master cli and confirm it is all working?
>
> On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Starting the vote for this
> >
> > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <da...@canonical.com>
> > wrote:
> >
> >> Hey,
> >>
> >> I would like to update the 4.x series of cordova-ubuntu with a couple of
> >> fixes, and make it the last in the series supporting the cordova-cli
> 4.3.1
> >> branch as well
> >>
> >>    - Cb 9868 - Should propose to install missing Ubuntu dependencies on
> >>    platform add <
> https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> >>    - Cb 9694 - Add support for HTTP urls
> >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> >>    - Cb 9806 - Add icon to project defaults
> >>    <https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> >>
> >> So here is the traditional:
> >>
> >> Does anyone have any reason to delay a cordova-ubuntu platform release?
> >> Any outstanding patches to land?
> >>
> >> If not, I will start the release tomorrow.
> >>
> >> David
> >>
> >
> >
>