You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2017/07/11 20:14:33 UTC
Review Request 60783: [ATLAS-1943] : Fix IT failure due to incorrect
inverse reference check using relationship
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60783/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1943
https://issues.apache.org/jira/browse/ATLAS-1943
Repository: atlas
Description
-------
Fix the following IT failures due to
Failed tests:
EntityJerseyResourceIT.testCompleteUpdate:952 » AtlasService Metadata service ...
EntityJerseyResourceIT.testPartialUpdate:877 » AtlasService Metadata service A...
After creating inverse reference, call is made to create relationship for ownedRef attribute. This call fails when an edge already exists. The edge exists as it was already created. Added getOrCreate relationship method to get a relationship if it exists, if not create a new relationship.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java 341711ac
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 8d9e4be8
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d5c1e862
Diff: https://reviews.apache.org/r/60783/diff/1/
Testing
-------
mvn clean package suceeded.
Thanks,
Sarath Subramanian
Re: Review Request 60783: [ATLAS-1943] : Fix IT failure due to
incorrect inverse reference check using relationship
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60783/#review180362
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 11, 2017, 8:14 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60783/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 8:14 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1943
> https://issues.apache.org/jira/browse/ATLAS-1943
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix the following IT failures due to
> Failed tests:
> EntityJerseyResourceIT.testCompleteUpdate:952 » AtlasService Metadata service ...
> EntityJerseyResourceIT.testPartialUpdate:877 » AtlasService Metadata service A...
> After creating inverse reference, call is made to create relationship for ownedRef attribute. This call fails when an edge already exists. The edge exists as it was already created. Added getOrCreate relationship method to get a relationship if it exists, if not create a new relationship.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java 341711ac
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 8d9e4be8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d5c1e862
>
>
> Diff: https://reviews.apache.org/r/60783/diff/1/
>
>
> Testing
> -------
>
> mvn clean package suceeded.
>
>
> Thanks,
>
> Sarath Subramanian
>
>