You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/15 21:44:27 UTC
[GitHub] [commons-io] marcwrobel opened a new pull request, #367: (chore) Fix minor typos
marcwrobel opened a new pull request, #367:
URL: https://github.com/apache/commons-io/pull/367
Fix various minor typos in :
- project documentations,
- javadoc and comments,
- private field, constant or method names,
- method attribute and variable names,
- test class and method names,
- exception messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] marcwrobel commented on a diff in pull request #367: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #367:
URL: https://github.com/apache/commons-io/pull/367#discussion_r922654194
##########
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java:
##########
@@ -404,7 +404,7 @@ public String readLine() throws IOException {
while (line == null) {
currentFilePart = currentFilePart.rollOver();
if (currentFilePart == null) {
- // no more fileparts: we're done, leave line set to null
+ // no more fileParts: we're done, leave line set to null
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #367: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-io/pull/367#discussion_r922582525
##########
src/main/java/org/apache/commons/io/StandardLineSeparator.java:
##########
@@ -28,7 +28,7 @@
public enum StandardLineSeparator {
/**
- * Carriage return. This is the line ending used on Macos 9 and earlier.
+ * Carriage return. This is the line ending used on Mac OS 9 and earlier.
Review Comment:
The proper spelling per Apple is "macOS"
##########
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java:
##########
@@ -404,7 +404,7 @@ public String readLine() throws IOException {
while (line == null) {
currentFilePart = currentFilePart.rollOver();
if (currentFilePart == null) {
- // no more fileparts: we're done, leave line set to null
+ // no more fileParts: we're done, leave line set to null
Review Comment:
This is still wrong: The type name is `FilePart`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #367: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #367:
URL: https://github.com/apache/commons-io/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] codecov-commenter commented on pull request #367: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #367:
URL: https://github.com/apache/commons-io/pull/367#issuecomment-1185978261
# [Codecov](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#367](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f72e131) into [master](https://codecov.io/gh/apache/commons-io/commit/4e2453500299951e6a2ee3aa62266b35baac1786?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e24535) will **increase** coverage by `0.04%`.
> The diff coverage is `57.89%`.
> :exclamation: Current head f72e131 differs from pull request most recent head f939510. Consider uploading reports for the commit f939510 to get more accurate results
```diff
@@ Coverage Diff @@
## master #367 +/- ##
============================================
+ Coverage 84.53% 84.57% +0.04%
- Complexity 2967 2968 +1
============================================
Files 193 193
Lines 7293 7293
Branches 916 916
============================================
+ Hits 6165 6168 +3
+ Misses 886 884 -2
+ Partials 242 241 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/commons/io/CloseableURLConnection.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vQ2xvc2VhYmxlVVJMQ29ubmVjdGlvbi5qYXZh) | `19.35% <0.00%> (ø)` | |
| [...c/main/java/org/apache/commons/io/EndianUtils.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRW5kaWFuVXRpbHMuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...rc/main/java/org/apache/commons/io/FileSystem.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRmlsZVN5c3RlbS5qYXZh) | `55.29% <ø> (ø)` | |
| [...in/java/org/apache/commons/io/FileSystemUtils.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRmlsZVN5c3RlbVV0aWxzLmphdmE=) | `76.87% <ø> (ø)` | |
| [src/main/java/org/apache/commons/io/FileUtils.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRmlsZVV0aWxzLmphdmE=) | `94.50% <ø> (ø)` | |
| [...main/java/org/apache/commons/io/FilenameUtils.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRmlsZW5hbWVVdGlscy5qYXZh) | `92.38% <ø> (ø)` | |
| [src/main/java/org/apache/commons/io/HexDump.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vSGV4RHVtcC5qYXZh) | `94.59% <ø> (ø)` | |
| [src/main/java/org/apache/commons/io/IOCase.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vSU9DYXNlLmphdmE=) | `91.17% <ø> (ø)` | |
| [...a/org/apache/commons/io/StandardLineSeparator.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vU3RhbmRhcmRMaW5lU2VwYXJhdG9yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...commons/io/comparator/CompositeFileComparator.java](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vY29tcGFyYXRvci9Db21wb3NpdGVGaWxlQ29tcGFyYXRvci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/commons-io/pull/367/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e24535...f939510](https://codecov.io/gh/apache/commons-io/pull/367?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] marcwrobel commented on a diff in pull request #367: (chore) Fix minor typos
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #367:
URL: https://github.com/apache/commons-io/pull/367#discussion_r922653282
##########
src/main/java/org/apache/commons/io/StandardLineSeparator.java:
##########
@@ -28,7 +28,7 @@
public enum StandardLineSeparator {
/**
- * Carriage return. This is the line ending used on Macos 9 and earlier.
+ * Carriage return. This is the line ending used on Mac OS 9 and earlier.
Review Comment:
It is now, but it was not when Mac OS 9 was released (cf. https://en.wikipedia.org/wiki/Mac_OS_9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org