[GitHub] [iceberg] huaxingao commented on a diff in pull request #6065: Fix TestAggregateBinding

[GitBox <gi...@apache.org>]

huaxingao commented on code in PR #6065:
URL: https://github.com/apache/iceberg/pull/6065#discussion_r1007578132


##########
api/src/test/java/org/apache/iceberg/expressions/TestAggregateBinding.java:
##########
@@ -18,44 +18,28 @@
  */
 package org.apache.iceberg.expressions;
 
-import java.util.Arrays;
 import java.util.List;
 import org.apache.iceberg.exceptions.ValidationException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
 import org.apache.iceberg.types.Types;
 import org.apache.iceberg.types.Types.StructType;
 import org.assertj.core.api.Assertions;
 import org.junit.Assert;
 import org.junit.Test;
 
 public class TestAggregateBinding {
-  private static final List<Expression.Operation> AGGREGATES =
-      Arrays.asList(Expression.Operation.COUNT, Expression.Operation.MAX, Expression.Operation.MIN);
+  private static final List<UnboundAggregate> list =

Review Comment:
   Fixed. Thanks! I accidentally put `String` type in the factory methods. It should be `T`. I fixed that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org