[jira] [Commented] (STORM-1233) port backtype.storm.security.auth.AuthUtils-test to java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183138#comment-15183138 ] 

ASF GitHub Bot commented on STORM-1233:
---------------------------------------

GitHub user abellina opened a pull request:

    https://github.com/apache/storm/pull/1191

    STORM-1233: Port AuthUtilsTest to java

    I did a little bit of refactoring in AuthUtils:
    - Using Hex.encodeHexString in makeDigestPayload instead of StringBuilder and String.format
    - Factored out the reflective class instantiations as a generic functions.
    - Added a null check in updateSubject
    
    I am also using JUnit TemporaryFolder to create temp folders which should be deleted after the test runs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abellina/storm STORM-1233_port_AuthUtils_test_to_java

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1191
    
----
commit b795bd7e47e79f1e6b063db543b6d8fbfd3620f3
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date:   2016-02-29T13:49:07Z

    STORM-1233: Port AuthUtilsTest to java

----


> port backtype.storm.security.auth.AuthUtils-test to java
> --------------------------------------------------------
>
>                 Key: STORM-1233
>                 URL: https://issues.apache.org/jira/browse/STORM-1233
>             Project: Apache Storm
>          Issue Type: New Feature
>            Reporter: Robert Joseph Evans
>            Assignee: Alessandro Bellina
>              Labels: java-migration, jstorm-merger
>
> Just a test moving to junit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)