You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Mark Lundquist <ml...@wrinkledog.com> on 2006/11/09 21:06:04 UTC

Submitting patches in JIRA

Hi,

Back in the day, with Bugzilla, I remember we had the convention that 
the issue title started with '[PATCH]'.  If there was no patch 
available when the issue was created, you just edited the issue title 
and inserted '[PATCH]'.

I see that with JIRA, there is this little "a patch is available with 
this issue" checkbox on the issue creation page.  Funny, I never 
noticed that before... :-).  Ah, now it all clicks... I guess that's 
where that "open-with-patch" report comes from :-)

And I guess the old convention of starting with '[PATCH]' is 
superfluous now, right?  That's good, because there doesn't seem to be 
any way to edit the title... maybe I don't have the right 
karma/mojo/whatever.  All I have to do is check the little box... but 
wait!  There's no little box anymore once the issue's been created.  
And there's no "this is a patch" checkbox on the Attach File form...

SooOOOooo... if I create an issue w/ no patch, then decide to submit a 
patch later, how do I indicate it?  Create a new issue referencing the 
first?  Or just attach the file and don't worry about it? :-)

—ml—


Re: Submitting patches in JIRA

Posted by Joerg Heinicke <jo...@gmx.de>.
Mark Lundquist <ml <at> wrinkledog.com> writes:

> And I guess the old convention of starting with '[PATCH]' is 
> superfluous now, right?

It is indeed no longer necessary to prefix the title as you can see in the
recent COCOON-open-with-patch mails:
http://article.gmane.org/gmane.text.xml.cocoon.devel/68318. Also issues without
prefixed titles are included.

Jörg


Re: Submitting patches in JIRA

Posted by Andrew Savory <an...@luminas.co.uk>.
Hi,

On 14 Nov 2006, at 06:18, David Crossley wrote:

> So, Cocoon PMC, should we loosen the permissions for Edit?
> Lazy consensus: if we don't hear a "no" then i will do it
> next week.

+1


Thanks,

Andrew.
--
Andrew Savory, Managing Director, Luminas Limited
Tel: +44 (0)870 741 6658  Fax: +44 (0)700 598 1135
Web: http://www.luminas.co.uk/
Sourcesense: http://www.sourcesense.com/



Re: Submitting patches in JIRA

Posted by Andreas Hochsteger <an...@gmail.com>.
+1
Andreas

2006/11/14, Ralph Goers <Ra...@dslextreme.com>:
> +1
>
> David Crossley wrote:
> > Ah, i see what is happening. Only people in the Jira group
> > "cocoon-developers" (i.e. committers) can Edit issues.
> >
> > Some other projects also enable "jira-users" to Edit, i.e. change
> > Summary, Description, Components, Fix Version, etc.
> >
> > So, Cocoon PMC, should we loosen the permissions for Edit?
> > Lazy consensus: if we don't hear a "no" then i will do it
> > next week.
> >
> > By the way, all "cocoon-developers" can do "Administer Project",
> > so no need to wait for me for this sort of stuff.
> >
> > -David
> >
>


-- 
Andreas

Re: Submitting patches in JIRA

Posted by Ralph Goers <Ra...@dslextreme.com>.
+1

David Crossley wrote:
> Ah, i see what is happening. Only people in the Jira group
> "cocoon-developers" (i.e. committers) can Edit issues.
>
> Some other projects also enable "jira-users" to Edit, i.e. change
> Summary, Description, Components, Fix Version, etc.
>
> So, Cocoon PMC, should we loosen the permissions for Edit?
> Lazy consensus: if we don't hear a "no" then i will do it
> next week.
>
> By the way, all "cocoon-developers" can do "Administer Project",
> so no need to wait for me for this sort of stuff.
>
> -David
>   

Re: Submitting patches in JIRA

Posted by Bertrand Delacretaz <bd...@apache.org>.
On 11/14/06, David Crossley <cr...@apache.org> wrote:
> ...Some other projects also enable "jira-users" to Edit, i.e. change
> Summary, Description, Components, Fix Version, etc.
>
> So, Cocoon PMC, should we loosen the permissions for Edit?..

+1, this is useful.

-Bertrand

Re: Submitting patches in JIRA

Posted by David Crossley <cr...@apache.org>.
Mark Lundquist wrote:
> David Crossley wrote:
> 
> >Use the "Edit this issue" link on the left-hand panel
> >when you are viewing an issue.
> 
> It's not there for me.  I have "Attach File", "Attach Screenshot", 
> "Clone", "Comment", "Create sub-task", "Voting", and "Watching".

Ah, i see what is happening. Only people in the Jira group
"cocoon-developers" (i.e. committers) can Edit issues.

Some other projects also enable "jira-users" to Edit, i.e. change
Summary, Description, Components, Fix Version, etc.

So, Cocoon PMC, should we loosen the permissions for Edit?
Lazy consensus: if we don't hear a "no" then i will do it
next week.

By the way, all "cocoon-developers" can do "Administer Project",
so no need to wait for me for this sort of stuff.

-David

Re: Submitting patches in JIRA

Posted by Mark Lundquist <ml...@wrinkledog.com>.
On Nov 12, 2006, at 9:13 PM, David Crossley wrote:

> Use the "Edit this issue" link on the left-hand panel
> when you are viewing an issue.

It's not there for me.  I have "Attach File", "Attach Screenshot", 
"Clone", "Comment", "Create sub-task", "Voting", and "Watching".

—ml—


Re: Submitting patches in JIRA

Posted by David Crossley <cr...@apache.org>.
Mark Lundquist wrote:
> 
> Back in the day, with Bugzilla, I remember we had the convention that 
> the issue title started with '[PATCH]'.  If there was no patch 
> available when the issue was created, you just edited the issue title 
> and inserted '[PATCH]'.
> 
> I see that with JIRA, there is this little "a patch is available with 
> this issue" checkbox on the issue creation page.  Funny, I never 
> noticed that before... :-).  Ah, now it all clicks... I guess that's 
> where that "open-with-patch" report comes from :-)
> 
> And I guess the old convention of starting with '[PATCH]' is 
> superfluous now, right?  That's good, because there doesn't seem to be 
> any way to edit the title... maybe I don't have the right 
> karma/mojo/whatever.  All I have to do is check the little box... but 
> wait!  There's no little box anymore once the issue's been created.  
> And there's no "this is a patch" checkbox on the Attach File form...
> 
> SooOOOooo... if I create an issue w/ no patch, then decide to submit a 
> patch later, how do I indicate it?  Create a new issue referencing the 
> first?  Or just attach the file and don't worry about it? :-)

Use the "Edit this issue" link on the left-hand panel
when you are viewing an issue.

-David

Re: Submitting patches in JIRA

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Mark Lundquist wrote:
> SooOOOooo... if I create an issue w/ no patch, then decide to submit a 
> patch later, how do I indicate it?  Create a new issue referencing the 
> first?  Or just attach the file and don't worry about it? :-)

If I had to guess I'd say best recourse is to upgrade to BugZilla :-P

Vadim