You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2019/02/25 19:11:42 UTC
Review Request 70052: RANGER-2340:Add Policy Version to the Ranger
Audit log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2340
https://issues.apache.org/jira/browse/RANGER-2340
Repository: ranger
Description
-------
RANGER-2340:Add Policy Version to the Ranger Audit log
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7
agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 289ec9b
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a
security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617
security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01
security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13
security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae
security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 0b47ba7
Diff: https://reviews.apache.org/r/70052/diff/1/
Testing
-------
Tested in Local VM
Thanks,
Ramesh Mani
Re: Review Request 70052: RANGER-2340:Add Policy Version to the
Ranger Audit log
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On Feb. 25, 2019, 11:45 p.m., Abhay Kulkarni wrote:
> > security-admin/contrib/solr_for_audit_setup/conf/managed-schema
> > Lines 94 (patched)
> > <https://reviews.apache.org/r/70052/diff/1/?file=2126695#file2126695line94>
> >
> > Should the type be "long"? Please review.
tlong is the type which we use in solr for long values
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/#review213191
-----------------------------------------------------------
On March 6, 2019, 4:13 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70052/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 4:13 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2340
> https://issues.apache.org/jira/browse/RANGER-2340
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2340:Add Policy Version to the Ranger Audit log
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7
> agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a
> hive-agent/pom.xml 53f6e2f
> security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617
> security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a43d076
> security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13
> security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae
> security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js 4027132
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js da0078f
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f20b2e8
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 26b43f7
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java ef4865a
>
>
> Diff: https://reviews.apache.org/r/70052/diff/2/
>
>
> Testing
> -------
>
> Tested in Local VM
>
> - Added Policy Version to UI
> - Added Policy Version to UI / pop up window when policy details are selected.
> - Fixed a test failure.
> - Upgrade path to address the solr schema would be manual which will be documented.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70052: RANGER-2340:Add Policy Version to the
Ranger Audit log
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/#review213191
-----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java
Line 137 (original), 140 (patched)
<https://reviews.apache.org/r/70052/#comment299058>
Will it be better to not change existing API, but introduce another one? The old API implementation will call new API with policyVersion as null. This will have a better chance of not breaking plugin code written for old API. Please review.
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Line 576 (original), 576 (patched)
<https://reviews.apache.org/r/70052/#comment299059>
There is no change from the previous version (except whitespaces). Please consider reverting it.
security-admin/contrib/solr_for_audit_setup/conf/managed-schema
Lines 94 (patched)
<https://reviews.apache.org/r/70052/#comment299057>
Should the type be "long"? Please review.
- Abhay Kulkarni
On Feb. 25, 2019, 7:11 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70052/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 7:11 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2340
> https://issues.apache.org/jira/browse/RANGER-2340
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2340:Add Policy Version to the Ranger Audit log
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7
> agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 289ec9b
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a
> security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617
> security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01
> security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13
> security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae
> security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 0b47ba7
>
>
> Diff: https://reviews.apache.org/r/70052/diff/1/
>
>
> Testing
> -------
>
> Tested in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70052: RANGER-2340:Add Policy Version to the
Ranger Audit log
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/#review213502
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On March 6, 2019, 4:13 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70052/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 4:13 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2340
> https://issues.apache.org/jira/browse/RANGER-2340
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2340:Add Policy Version to the Ranger Audit log
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7
> agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a
> hive-agent/pom.xml 53f6e2f
> security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617
> security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a43d076
> security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13
> security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae
> security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js 4027132
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js da0078f
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f20b2e8
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 26b43f7
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java ef4865a
>
>
> Diff: https://reviews.apache.org/r/70052/diff/2/
>
>
> Testing
> -------
>
> Tested in Local VM
>
> - Added Policy Version to UI
> - Added Policy Version to UI / pop up window when policy details are selected.
> - Fixed a test failure.
> - Upgrade path to address the solr schema would be manual which will be documented.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70052: RANGER-2340:Add Policy Version to the
Ranger Audit log
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70052/
-----------------------------------------------------------
(Updated March 6, 2019, 4:13 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Address review comments.
Bugs: RANGER-2340
https://issues.apache.org/jira/browse/RANGER-2340
Repository: ranger
Description
-------
RANGER-2340:Add Policy Version to the Ranger Audit log
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7b806e7
agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java be22df7
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 8d97e99
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java c4e7b75
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b29f152
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 466f22a
hive-agent/pom.xml 53f6e2f
security-admin/contrib/solr_for_audit_setup/conf/managed-schema 2cfd617
security-admin/db/mysql/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/oracle/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/postgres/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/db/sqlserver/patches/038-add-column-version-in-x_policy_export_audit.sql PRE-CREATION
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyExportAudit.java 4060e01
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a43d076
security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditServiceBase.java 51711a8
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 1b49c13
security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 1fe85ae
security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAudit.java 8fca5ba
security-admin/src/main/webapp/scripts/models/RangerPolicy.js 4027132
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js cce9358
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js da0078f
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f20b2e8
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 26b43f7
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java ef4865a
Diff: https://reviews.apache.org/r/70052/diff/2/
Changes: https://reviews.apache.org/r/70052/diff/1-2/
Testing (updated)
-------
Tested in Local VM
- Added Policy Version to UI
- Added Policy Version to UI / pop up window when policy details are selected.
- Fixed a test failure.
- Upgrade path to address the solr schema would be manual which will be documented.
Thanks,
Ramesh Mani