You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bso-intel <gi...@git.apache.org> on 2016/02/14 21:58:51 UTC
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/387
CB-10550 Fixed the issue of plugin id mapper not enforced when a vers…
…ion is specified
The issue is described in https://issues.apache.org/jira/browse/CB-10550
The fix is to inspect the given plugin_src if it contains the '@'<version_number> before it tries to find the mapper database.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso-intel/cordova-lib CB-10550
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #387
----
commit fab318eca7bf3aa7fe0c454628ecbbf058840ff9
Author: Byoungro So <by...@intel.com>
Date: 2016-02-14T20:52:10Z
CB-10550 Fixed the issue of plugin id mapper not enforced when a version is specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-185005103
Thanks @bso-intel. I've merged this in https://github.com/apache/cordova-lib/commit/87d8e171, but I rebased on forgot to add "This closes #387" to the comment, so if you could close this PR manually that'd be great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-184998947
Hi @TimBarham
Thanks for reviewing this pull request.
I updated the comment as you requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/387#discussion_r52976299
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,10 +132,14 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
));
}
// If not found in local search path, fetch from the registry.
- var newID = pluginMapperotn[plugin_src];
+ var splitVersion = plugin_src.split('@');
+ var newID = pluginMapperotn[splitVersion[0]];
if(newID) {
events.emit('warn', 'Notice: ' + plugin_src + ' has been automatically converted to ' + newID + ' to be fetched from npm. This is due to our old plugins registry shutting down.');
--- End diff --
Looks great, thanks @bso-intel!
One small nit - use `splitVersion[0]` in the message instead of `plugin_src` (so, for example, we get `org.apache.cordova.device has been automatically converted to cordova-plugin-device to be fetched from npm` instead of `org.apache.cordova.device@1.1.1 has been automatically converted to cordova-plugin-device to be fetched from npm`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel closed the pull request at:
https://github.com/apache/cordova-lib/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org